Skip to content

Commit

Permalink
CR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
salvacorts committed Nov 25, 2024
1 parent a12cf8c commit f9da45d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/loghttp/push/push.go
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ func OTLPError(w http.ResponseWriter, error string, code int, logger log.Logger)
level.Error(logger).Log("msg", "failed to marshal error response", "error", err)
writeResponseFailedBody, _ := proto.Marshal(grpcstatus.New(
codes.Internal,
fmt.Sprintf("failed to marshal error response. original error: %s", err.Error()),
fmt.Sprintf("failed to marshal error response: %s", err.Error()),
).Proto())
_, _ = w.Write(writeResponseFailedBody)
return
Expand All @@ -356,7 +356,7 @@ func OTLPError(w http.ResponseWriter, error string, code int, logger log.Logger)
level.Error(logger).Log("msg", "failed to write error response", "error", err)
writeResponseFailedBody, _ := proto.Marshal(grpcstatus.New(
codes.Internal,
fmt.Sprintf("failed write error. original error: %s", err.Error()),
fmt.Sprintf("failed write error: %s", err.Error()),
).Proto())
_, _ = w.Write(writeResponseFailedBody)
}
Expand Down

0 comments on commit f9da45d

Please sign in to comment.