-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to configure Mimir alertmanager #447
base: main
Are you sure you want to change the base?
Conversation
…imir-alertmanager-config
Thanks for this contribution! We can look at it next week. In the meantime, there's a few lint type things noted in the PR. Can you review them? |
Will do when possible, please note that the changes are not final, some tests are missing and some features like Another important note that I think will need some further discussion here is that there's no name and/or uid for such object and I truly don't know how to handle it. |
How did @theSuess handle it for the equivalent Grafana resource? I think the pattern is already there. |
Good point, seems like the implementation is based on having a static name/uid for said object, I could try to align my implementation with theirs. |
…taykal/grizzly into feat/mimir-alertmanager-config
Another issue I'm currently having is that |
fixes #387
This PR fixes some comments, namings and object specific errors (which shouldn't be this specific)