Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus native histograms are NOT scraped in static mode #7056

Closed
Reimirno opened this issue Oct 17, 2024 · 3 comments
Closed

Prometheus native histograms are NOT scraped in static mode #7056

Reimirno opened this issue Oct 17, 2024 · 3 comments
Labels
bug Something isn't working frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Comments

@Reimirno
Copy link

Reimirno commented Oct 17, 2024

What's wrong?

A similar issue for flow mode has been raised in #5136 and fixed in #5335

However, it seems that for static mode agent there is still no way to configure EnableProtobufNegotiation on prometheus.

This is needed for agent to be able to scrape native histogram. You need this turned on for prometheus to be able to send correct header and request protobuf. See src here.

Steps to reproduce

no such option in static/config/config.go

System information

No response

Software version

No response

Configuration

No response

Logs

No response

@Reimirno Reimirno added the bug Something isn't working label Oct 17, 2024
@Reimirno Reimirno changed the title Prometheus native histograms are scraped in static mode Prometheus native histograms are NOT scraped in static mode Oct 17, 2024
Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Nov 17, 2024
@Reimirno
Copy link
Author

I have a small PR to fix this - Can someone take a look? #7057
Thank you :)

@github-actions github-actions bot removed the needs-attention An issue or PR has been sitting around and needs attention. label Nov 19, 2024
@ptodev
Copy link
Contributor

ptodev commented Dec 18, 2024

Hello! Apologies, we no longer add new features to static mode. Please look into migrating to Alloy instead.

@ptodev ptodev closed this as completed Dec 18, 2024
@ptodev ptodev closed this as not planned Won't fix, can't repro, duplicate, stale Dec 18, 2024
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Jan 18, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
2 participants