Skip to content

Fix potential use-after-free for v8 isolates #164

@stroiman

Description

@stroiman

When a V8 ScriptHost is closed, it is returned to a pool of isolates, optimizing construction of new isolates. However is code holds on to the ScriptHost, it could lead to a use-after-free bug.

Consider returning a proxy, whose implementation pointer is reset to nil after closing.

Same issue could be applied to other script engines, if they cache script hosts.

Metadata

Metadata

Assignees

No one assigned

    Labels

    refactorA task that is a refactoring task itself, or depends on a refactoring first

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions