Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support for proxying websocket through https proxy #739

Open
philipatl opened this issue Dec 3, 2021 · 1 comment · May be fixed by #740 or #950
Open

[feature] Support for proxying websocket through https proxy #739

philipatl opened this issue Dec 3, 2021 · 1 comment · May be fixed by #740 or #950

Comments

@philipatl
Copy link

philipatl commented Dec 3, 2021

Is your feature request related to a problem? Please describe.

I need to use a proxy server that itself requires TLS (proxy URL has https scheme).

Describe the solution you'd like

I should be able to use a proxy server (eg, via ProxyFromEnvironment) that has an https scheme and uses TLS. Currently, proxy_RegisterDialerType only registers the 'http' scheme.
This should also be able to use my client TLSClientConfig which could be necessary to communicate with my proxy.

Describe alternatives you've considered
I do not see any other alternatives. The workaround suggested in comments below on 12/3/21 is impractical, especially when using ProxyFromEnvironment and applying this to other libraries. I should not have to mangle my proxy scheme to get this to work.

@philipatl philipatl linked a pull request Dec 3, 2021 that will close this issue
@ghost
Copy link

ghost commented Dec 3, 2021

Possible workaround:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

3 participants