Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Ads Personalization & Data" not working on Linux #344

Open
TheKodeToad opened this issue Jun 9, 2024 · 2 comments
Open

"Ads Personalization & Data" not working on Linux #344

TheKodeToad opened this issue Jun 9, 2024 · 2 comments

Comments

@TheKodeToad
Copy link

TheKodeToad commented Jun 9, 2024

Version: 2.0.20 (AppImage)
Operating System: Fedora Linux 40 (Workstation Edition)

When going to Settings -> Privacy and pressing Manage next to Ads Personalization & Data, nothing opens.

This is also visible in the log.

19:16:36.147 › Error occurred in handler for 'openCMPWindow': TypeError: Cannot read properties of undefined (reading 'openCMPWindow')
    at /tmp/.mount_GDLaunVBf7ym/resources/app.asar/dist/main/index.cjs:105:40935
    at WebContents.<anonymous> (node:electron/js2c/browser_init:2:77976)
    at WebContents.emit (node:events:517:28)
    at WebContents.emit (node:domain:489:12)
    at i.emit (/tmp/.mount_GDLaunVBf7ym/resources/app.asar/dist/main/index.cjs:42:200016)

I would assume this traces back to this line which doesn't seem to do a nullish check:

app.overwolf.openCMPWindow();

I guess this isn't available on Linux? Maybe hide the button.

@blarfoon
Copy link
Member

blarfoon commented Jun 9, 2024

Yes I think this is a mistake in my end. Linux doesn't have dynamic ads so that button should be a no-op

@blarfoon
Copy link
Member

blarfoon commented Jun 9, 2024

will be fixed soon, althought I am still working on other fixes so I don't have an ETA yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants