Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDRP Support #39

Open
sergiobd opened this issue Oct 21, 2019 · 15 comments
Open

HDRP Support #39

sergiobd opened this issue Oct 21, 2019 · 15 comments

Comments

@sergiobd
Copy link

Any suggestions on how to import the brushes correctly in Unity when using HDRP?

@dubois
Copy link
Contributor

dubois commented Oct 21, 2019

I've never used the HDRP. Many of the materials use relatively straightforward surface shaders, and all the shaders are written so they work mostly the same whether you're using srgb or linear lighting.

@andybak
Copy link

andybak commented Oct 21, 2019

Unfortunately surface shaders are one of the things unsupported in the new rendering pipelines. They are heavily tied into the old pipeline.

However I'm not sure many of the Toolkit shaders really need to be surface shaders. Most would be pretty easy to reproduce using normal vertex/fragment shaders or even reimplemented using Shadergraph.

The only problem is that there are quite a few of them.

My question to @sergiobd would be - are you using a big number of different shaders and are they the funky animated ones or simpler ones that could probably be replaced from scratch fairly easily?

@sergiobd
Copy link
Author

Hey! Thanks for your extremely quick answer! No funkiness, I'm going to use the simple ones.
The problem with HDRP is that the process for writing shaders is still a bit obscure. It is suggested to use ShaderGraph. I'm going to look into that.

@sergiobd
Copy link
Author

sergiobd commented Oct 30, 2019

Hi @andybak and @dubois,

So, I can confirm that the brushes that are coded as fragment shaders do import fine in HDRP (I tested with "snow" and "comet"). I did a quick test using ShaderGraph to see how easy it was to port the surface shaders, and it looks it's indeed pretty easy. I tested with the Oil Paint brush, which uses the Standard Double Sided shader. Note that I'm connecting the output of the normal map directly into the master node. Therefore, I'm assuming all the lighting and shading is handled internally by Unity.

image

@dubois
Copy link
Contributor

dubois commented Nov 6, 2019

I'm going to leave this open as a discussion space, but the shaders in the Toolkit cannot diverge significantly from the ones used in Tilt Brush. If anyone does create an alternate set of shaders that works well with other render pipelines, link to your repo here and I'll promote it into our README

@gilasher
Copy link

Any updates regarding importing Tiltbrush materials into unity HDRP?
TNX

@dubois
Copy link
Contributor

dubois commented Apr 15, 2020

No change. Tilt Brush still does not use HDRP internally, and therefore the shaders exported from Tilt Brush do not support HDRP. It looks like nobody is interested in contributing any, either.

@sergiobd
Copy link
Author

@gilasher, the Tiltbrush standard shaders have a simple implementation, and therefore it was relatively easy to make similar ones on shadergraph (at least to fit my own purpose). I can send a graph to you if you want.

@gilasher
Copy link

@sergiobd I'll really appreciate it, Thanks! My shading skills aren't very good, so I get stuck even with the simple things! It would be very helpful if you can share it!

@Dennisrudolph
Copy link

I am also having this problem. Unfortunately I have no idea how a shader graph works. Could you help me out? Maybe send me the updated tiltbrush shaders for HDRP? Highly appreciated ! Thanks. Dennis

@sergiobd
Copy link
Author

sergiobd commented Jun 3, 2020

@gilasher @Dennisrudolph, I added a small repo with the shader graphs in case you still need them.

@Dennisrudolph
Copy link

Dennisrudolph commented Jun 6, 2020 via email

@gilasher
Copy link

gilasher commented Jun 6, 2020

@sergiobd thank you! it is very helpful

@VKolbasa
Copy link

Hi Sergio!

Could you send it to me also pleeease? Need it urgently! :) [email protected]

Volo

@sergiobd
Copy link
Author

Hi Volodymir, its here :
https://github.com/sergiobd/TiltbrushHDRP/tree/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants