Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix release-to-publish workflow #482

Merged
merged 1 commit into from
Aug 2, 2024
Merged

chore: fix release-to-publish workflow #482

merged 1 commit into from
Aug 2, 2024

Conversation

wangela
Copy link
Member

@wangela wangela commented Aug 1, 2024

  1. The release worfklow is failing because the call to the publish workflow requires checkout first, which must not be handled under a separate conditional.

  2. Release Please is unable to distinguish between version numbers of this package that should be bumped up with each release vs other strings that represent version numbers but shouldn't be bumped. This causes an extra manual commit on the release PR to correct the edits that release-please makes. Since the README has 3 strings that shouldn't be bumped and 1 instance that should be bumped, we will manually update the bump until Release Please can support a more detailed regex (feature request in Support custom regex for x-release-please-* annotations in extra-files googleapis/release-please#2345)

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@wangela wangela requested a review from a team as a code owner August 1, 2024 18:20
@wangela wangela requested a review from willum070 August 1, 2024 18:20
@wangela wangela merged commit 3b47119 into main Aug 2, 2024
10 checks passed
@wangela wangela deleted the wangela/release branch August 2, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants