Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move maps-rx snippets to app-rx snippets app #1438

Open
wangela opened this issue Dec 20, 2023 · 0 comments
Open

Move maps-rx snippets to app-rx snippets app #1438

wangela opened this issue Dec 20, 2023 · 0 comments
Labels
api: docs Issues related to the Docs API API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@wangela
Copy link
Contributor

wangela commented Dec 20, 2023

Currently the snippets for Maps RX are in the snippets/app (introduced in #902).

Now that we have separate snippet apps for the various libraries, we should move those files to https://github.com/googlemaps-samples/android-samples/tree/main/snippets/app-rx.

I suspect that the Rx snippets might have minSDK 24 so once these move out of snippets/app (meant for the Maps SDK for Android alone), we can revert minSDK for snippets/app to 21.
@wangela wangela added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. triage me I really want to be triaged. type: cleanup An internal cleanup or hygiene concern. api: docs Issues related to the Docs API API. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. triage me I really want to be triaged. labels Dec 20, 2023
@googlemaps-samples googlemaps-samples deleted a comment Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: docs Issues related to the Docs API API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wangela