Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert FilterChain in Config into map of FilterChain #699

Open
XAMPPRocky opened this issue Feb 10, 2023 · 3 comments
Open

Convert FilterChain in Config into map of FilterChain #699

XAMPPRocky opened this issue Feb 10, 2023 · 3 comments
Labels
kind/feature New feature or request

Comments

@XAMPPRocky
Copy link
Collaborator

With #698 and the ability to share cluster configuration between proxies, control planes, and relays, it might be worth also making filter chain configuration possible to contain multiple FilterChains at a given time that can be updated through a configuration provider, and allow the proxies to be configured to set their filter chain in the CLI.

As a bonus this would also allow for a filter that calls FilterChain which could be combined with other filters such as capture and match to allow you to dynamically switch filter chains.

@XAMPPRocky XAMPPRocky added the kind/feature New feature or request label Feb 10, 2023
@markmandel
Copy link
Contributor

🤔 is this similar to the Match filter, but allowing to pass through data to a FilterChain, rather than just a single filter?

@XAMPPRocky
Copy link
Collaborator Author

is this similar to the Match filter, but allowing to pass through data to a FilterChain, rather than just a single filter?

There's two parts. The first is that our configuration schema moves from FilterChain to [(str, FilterChain)], this allows multiple filter chains to exist at the same time. This is important for the control planes and the relay because it would allow them to discover multiple filter chain definitions without overriding each other.

The second part is that leveraging that new schema we can also add filter that references a filter chain to execute it.

@markmandel
Copy link
Contributor

That makes a lot of sense 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants