Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add absl::Cord to storage/async/write_payload.h constructors #14868

Open
laramiel opened this issue Dec 3, 2024 · 0 comments
Open

Add absl::Cord to storage/async/write_payload.h constructors #14868

laramiel opened this issue Dec 3, 2024 · 0 comments
Assignees
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@laramiel
Copy link

laramiel commented Dec 3, 2024

What component of google-cloud-cpp is this feature request for?
google/cloud/storage async api

Is your feature request related to a problem? Please describe.
I have absl::Cord data to write to GCS; the current api uses absl::Cord internally but does not allow passing a Cord to the call.

Describe the solution you'd like
Add the following constructor:

  explicit WritePayload(absl::Cord p) : impl_(std::move(p)) {}
@laramiel laramiel added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Dec 3, 2024
@scotthart scotthart added the api: storage Issues related to the Cloud Storage API. label Dec 3, 2024
@ddelgrosso1 ddelgrosso1 self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants