Make metadata timeout more accessible and controlleable for AppEngine stubs. #1518
+53
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the logic to read GCE_METADATA_TIMEOUT env variable so we can better control it in app_identity component. Related internal change is 607513254.
ludoch
changed the title
arithmetic1728
requested changes
Apr 13, 2024
There was a problem hiding this comment.
Thank you for the pull request!
Could you add a chore: prefix to your commit message like chore: make metadata...?
There are also a few kokoro build failures.
(1) lint failure. You can run python -m nox -s blacken to format the files, then python -m nox -s lint to verify.
(2) unit test failures - METADATA_HEADERS instead of METADATA_HEADER
(3) after the unit test code is fixed, please run python -m nox -s cover to see if all tests and the coverage check can pass (this repo requires 100% code coverage)
Thanks!
| @@ -105,8 +105,45 @@ def test_ping_success(mock_metrics_header_value): | |||
| request.assert_called_once_with( | |||
| method="GET", | |||
| url=_metadata._METADATA_IP_ROOT, | |||
| headers=MDS_PING_REQUEST_HEADER, | |||
| timeout=_metadata._METADATA_DEFAULT_TIMEOUT, | |||
| headers=_metadata._METADATA_HEADER, | |||
| request.assert_called_once_with( | ||
| method="GET", | ||
| url=_metadata._METADATA_IP_ROOT, | ||
| headers=_metadata._METADATA_HEADER, |
|
Looks like you have an older PR for this as well, #1481. Should we close that PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.