Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoogleAuthorizationCodeFlow Won't Work With non-AppEngine #2256

Open
bcwhite-code opened this issue Feb 10, 2023 · 2 comments
Open

GoogleAuthorizationCodeFlow Won't Work With non-AppEngine #2256

bcwhite-code opened this issue Feb 10, 2023 · 2 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bcwhite-code
Copy link

https://developers.google.com/api-client-library/java/google-api-java-client/oauth2

The GoogleAuthorizationCodeFlow class needs, for persistence, a DataStoreFactory. However, this appears to be accessible only with AppEngine because the Cloud-Run library provides instead a DatastoreFactory (small S).

This dependency goes down event into the AuthorizationCodeFlow base class making it (seemingly) impossible for me to create a custom derived class that manages the persistence on my terms.

It would be nice if the base class was independent of the storage type, using function calls that can be overridden.

@Edwardiv1
Copy link

Have you tried com.google.api.client.util.store.FileDataStoreFactory ?

@bcwhite-code
Copy link
Author

I saw that class but I need it stored in Google's Datastore, not in the filesystem of the container. There's no guarantee that the incoming redirect will go to the same instance.

@JoeWang1127 JoeWang1127 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants