From e6ef68af71f43f977b17b59056562c282fe62356 Mon Sep 17 00:00:00 2001 From: David Majnemer Date: Sun, 29 Dec 2024 03:44:25 -0800 Subject: [PATCH] Remove //third_party/libdoubleconversion dependency from TensorFlow No longer needed now that we are using the code in absl PiperOrigin-RevId: 710458187 --- opensource_only.files | 1 - third_party/systemlibs/double_conversion.BUILD | 12 ------------ third_party/systemlibs/syslibs_configure.bzl | 1 - tsl/platform/BUILD | 1 - workspace2.bzl | 8 -------- 5 files changed, 23 deletions(-) delete mode 100644 third_party/systemlibs/double_conversion.BUILD diff --git a/opensource_only.files b/opensource_only.files index 31bb0699a..49ade578d 100644 --- a/opensource_only.files +++ b/opensource_only.files @@ -132,7 +132,6 @@ third_party/systemlibs/boringssl.BUILD: third_party/systemlibs/build_defs.bzl.tpl: third_party/systemlibs/curl.BUILD: third_party/systemlibs/cython.BUILD: -third_party/systemlibs/double_conversion.BUILD: third_party/systemlibs/gif.BUILD: third_party/systemlibs/google_cloud_cpp.BUILD: third_party/systemlibs/google_cloud_cpp.google.cloud.bigtable.BUILD: diff --git a/third_party/systemlibs/double_conversion.BUILD b/third_party/systemlibs/double_conversion.BUILD deleted file mode 100644 index 568460181..000000000 --- a/third_party/systemlibs/double_conversion.BUILD +++ /dev/null @@ -1,12 +0,0 @@ -licenses(["notice"]) - -filegroup( - name = "LICENSE", - visibility = ["//visibility:public"], -) - -cc_library( - name = "double-conversion", - linkopts = ["-ldouble-conversion"], - visibility = ["//visibility:public"], -) diff --git a/third_party/systemlibs/syslibs_configure.bzl b/third_party/systemlibs/syslibs_configure.bzl index f2fc22480..3c734e475 100644 --- a/third_party/systemlibs/syslibs_configure.bzl +++ b/third_party/systemlibs/syslibs_configure.bzl @@ -21,7 +21,6 @@ VALID_LIBS = [ "curl", "cython", "dill_archive", - "double_conversion", "flatbuffers", "functools32_archive", "gast_archive", diff --git a/tsl/platform/BUILD b/tsl/platform/BUILD index eb208e6ef..13414a247 100644 --- a/tsl/platform/BUILD +++ b/tsl/platform/BUILD @@ -212,7 +212,6 @@ cc_library( ":types", "@com_google_absl//absl/base:core_headers", "@com_google_absl//absl/strings", - "@double_conversion//:double-conversion", ], ) diff --git a/workspace2.bzl b/workspace2.bzl index 0b1bd5ee6..f3a237dd7 100644 --- a/workspace2.bzl +++ b/workspace2.bzl @@ -480,14 +480,6 @@ def _tf_repositories(): urls = tf_mirror_urls("https://github.com/cython/cython/archive/3.0.3.tar.gz"), ) - tf_http_archive( - name = "double_conversion", - sha256 = "3dbcdf186ad092a8b71228a5962009b5c96abde9a315257a3452eb988414ea3b", - strip_prefix = "double-conversion-3.2.0", - system_build_file = "//third_party/systemlibs:double_conversion.BUILD", - urls = tf_mirror_urls("https://github.com/google/double-conversion/archive/v3.2.0.tar.gz"), - ) - tf_http_archive( name = "build_bazel_rules_android", sha256 = "cd06d15dd8bb59926e4d65f9003bfc20f9da4b2519985c27e190cddc8b7a7806",