Skip to content

Commit 7a6c4ef

Browse files
authored
nat: Add flag for specified range in DNAT (#270)
Example: meta l4proto tcp dnat to 10.200.45.6:9080 [ meta load l4proto => reg 1 ] [ cmp eq reg 1 0x00000006 ] [ immediate reg 1 0x062dc80a ] [ immediate reg 2 0x00007823 ] [ nat dnat ip addr_min reg 1 proto_min reg 2 flags 0x2 ]
1 parent adb9846 commit 7a6c4ef

File tree

3 files changed

+73
-0
lines changed

3 files changed

+73
-0
lines changed

expr/expr.go

+2
Original file line numberDiff line numberDiff line change
@@ -336,6 +336,8 @@ const (
336336
NF_NAT_RANGE_PERSISTENT = unix.NF_NAT_RANGE_PERSISTENT
337337
// NF_NAT_RANGE_PREFIX defines flag for a prefix masquerade
338338
NF_NAT_RANGE_PREFIX = unix.NF_NAT_RANGE_NETMAP
339+
// NF_NAT_RANGE_PROTO_SPECIFIED defines flag for a specified range
340+
NF_NAT_RANGE_PROTO_SPECIFIED = unix.NF_NAT_RANGE_PROTO_SPECIFIED
339341
)
340342

341343
func (e *Masq) marshal(fam byte) ([]byte, error) {

expr/nat.go

+5
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ type NAT struct {
4141
FullyRandom bool
4242
Persistent bool
4343
Prefix bool
44+
Specified bool
4445
}
4546

4647
// |00048|N-|00001| |len |flags| type|
@@ -97,6 +98,9 @@ func (e *NAT) marshalData(fam byte) ([]byte, error) {
9798
if e.Prefix {
9899
flags |= NF_NAT_RANGE_PREFIX
99100
}
101+
if e.Specified {
102+
flags |= NF_NAT_RANGE_PROTO_SPECIFIED
103+
}
100104
if flags != 0 {
101105
attrs = append(attrs, netlink.Attribute{Type: unix.NFTA_NAT_FLAGS, Data: binaryutil.BigEndian.PutUint32(flags)})
102106
}
@@ -130,6 +134,7 @@ func (e *NAT) unmarshal(fam byte, data []byte) error {
130134
e.Random = (flags & NF_NAT_RANGE_PROTO_RANDOM) != 0
131135
e.FullyRandom = (flags & NF_NAT_RANGE_PROTO_RANDOM_FULLY) != 0
132136
e.Prefix = (flags & NF_NAT_RANGE_PREFIX) != 0
137+
e.Specified = (flags & NF_NAT_RANGE_PROTO_SPECIFIED) != 0
133138
}
134139
}
135140
return ad.Err()

expr/nat_test.go

+66
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
1+
package expr
2+
3+
import (
4+
"encoding/binary"
5+
"reflect"
6+
"testing"
7+
8+
"github.com/mdlayher/netlink"
9+
"golang.org/x/sys/unix"
10+
)
11+
12+
func TestNat(t *testing.T) {
13+
t.Parallel()
14+
tests := []struct {
15+
name string
16+
nat NAT
17+
}{
18+
{
19+
name: "Unmarshal DNAT specified case",
20+
nat: NAT{
21+
Type: NATTypeDestNAT,
22+
Family: unix.NFPROTO_IPV4,
23+
RegAddrMin: 1,
24+
RegProtoMin: 2,
25+
Specified: true,
26+
},
27+
},
28+
{
29+
name: "Unmarshal SNAT persistent case",
30+
nat: NAT{
31+
Type: NATTypeSourceNAT,
32+
Family: unix.NFPROTO_IPV4,
33+
RegAddrMin: 1,
34+
RegProtoMin: 2,
35+
Persistent: true,
36+
},
37+
},
38+
}
39+
40+
for _, tt := range tests {
41+
t.Run(tt.name, func(t *testing.T) {
42+
nnat := NAT{}
43+
data, err := tt.nat.marshal(0 /* don't care in this test */)
44+
if err != nil {
45+
t.Fatalf("marshal error: %+v", err)
46+
47+
}
48+
ad, err := netlink.NewAttributeDecoder(data)
49+
if err != nil {
50+
t.Fatalf("NewAttributeDecoder() error: %+v", err)
51+
}
52+
ad.ByteOrder = binary.BigEndian
53+
for ad.Next() {
54+
if ad.Type() == unix.NFTA_EXPR_DATA {
55+
if err := nnat.unmarshal(0, ad.Bytes()); err != nil {
56+
t.Errorf("unmarshal error: %+v", err)
57+
break
58+
}
59+
}
60+
}
61+
if !reflect.DeepEqual(tt.nat, nnat) {
62+
t.Fatalf("original %+v and recovered %+v Ct structs are different", tt.nat, nnat)
63+
}
64+
})
65+
}
66+
}

0 commit comments

Comments
 (0)