Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: FloatingEqMatcher doesn't work with const float value types #4462

Open
nickbrekhus opened this issue Feb 8, 2024 · 1 comment · May be fixed by #4463
Open

[Bug]: FloatingEqMatcher doesn't work with const float value types #4462

nickbrekhus opened this issue Feb 8, 2024 · 1 comment · May be fixed by #4463
Assignees
@dinord

Comments

@nickbrekhus
Copy link

nickbrekhus commented Feb 8, 2024 •
edited
Loading

Describe the issue

FloatingEqMatcher doesn't work with const float value types. See https://godbolt.org/z/zexhra9eG. A const conversion is missing

Steps to reproduce the problem

https://godbolt.org/z/zexhra9eG

What version of GoogleTest are you using?

trunk

What operating system and version are you using?

(see godbolt repro)

What compiler and version are you using?

clang 15

What build system are you using?

(see godbolt repro)

Additional context

No response
@nickbrekhus nickbrekhus linked a pull request Feb 8, 2024 that will close this issue
Open
@nickbrekhus nickbrekhus changed the title [Bug]: DoubleEq matcher with const float value types [Bug]: FloatingEqMatcher doesn't work with const float value types Feb 8, 2024
@nickbrekhus
Copy link
Author

@dinord Could you take a look? The issue/fix is pretty simple and avoids a pretty hard to understand diagnostic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dinord dinord

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FloatingEqMatcher supports conversion to const float types nickbrekhus/googletest
2 participants
@dinord @nickbrekhus