Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ngspice regression tests README to include information about how to interpret the results #71

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mkkassem
Copy link
Collaborator

Signed-off-by: Mohamed Kassem [email protected]

Fixes google/gf180mcu-pdk#93

  • a future update should include taking a point from the sim-vs-si report and show how an independent user can find what simulation and pvt corners that cause the error.

Signed-off-by: Mohamed Kassem <[email protected]>
@google-cla
Copy link

google-cla bot commented Nov 14, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Signed-off-by: Mohamed Kassem <[email protected]>
Signed-off-by: Mohamed Kassem <[email protected]>
@mkkassem mkkassem changed the title Update README.md Update ngspice regression tests README to include information about how to interpret the results Nov 14, 2022
@proppy
Copy link
Member

proppy commented Nov 15, 2022

Is that different from #72?

Signed-off-by: Mohamed Kassem <[email protected]>
Updated to generate the correct exit code for the CI to be meaningful.

Signed-off-by: Mohamed Kassem <[email protected]>
proppy pushed a commit to proppy/globalfoundries-pdk-libs-gf180mcu_fd_pr that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ngspice regression tests README to include information about how to interpret the results
2 participants