Metal deprecated functions warning stopping build

[Danielsirota]

Hey! I am trying to build filament using cmake for MacOS but am getting errors because of a few Metal deprecated functions warnings. Don't know if there is already a fix for this so any help would be great thanks!

Build errors:

[build] .../filament/filament/backend/src/metal/MetalState.mm:180:34: error: 'MTLArgumentAccessReadOnly' is deprecated: first deprecated in macOS 14.0 [-Werror,-Wdeprecated-declarations]
[build]         textureArgument.access = MTLArgumentAccessReadOnly;
[build]                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
[build]                                  MTLBindingAccessReadOnly
[build] /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/System/Library/Frameworks/Metal.framework/Headers/MTLArgument.h:222:5: note: 'MTLArgumentAccessReadOnly' has been explicitly marked deprecated here
[build]     MTLArgumentAccessReadOnly API_DEPRECATED_WITH_REPLACEMENT("MTLBindingAccessReadOnly", macos(10.13, 14.0), ios(8.0, 17.0)) = MTLBindingAccessReadOnly,
[build]     ^
[build] .../filament/filament/backend/src/metal/MetalState.mm:186:34: error: 'MTLArgumentAccessReadOnly' is deprecated: first deprecated in macOS 14.0 [-Werror,-Wdeprecated-declarations]
[build]         textureArgument.access = MTLArgumentAccessReadOnly;
[build]                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
[build]                                  MTLBindingAccessReadOnly
[build] /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/System/Library/Frameworks/Metal.framework/Headers/MTLArgument.h:222:5: note: 'MTLArgumentAccessReadOnly' has been explicitly marked deprecated here
[build]     MTLArgumentAccessReadOnly API_DEPRECATED_WITH_REPLACEMENT("MTLBindingAccessReadOnly", macos(10.13, 14.0), ios(8.0, 17.0)) = MTLBindingAccessReadOnly,
[build]     ^
[build] 2 errors generated.
[build] make[2]: *** [.../filament/filament/backend/CMakeFiles/backend.dir/src/metal/MetalState.mm.o] Error 1
[build] make[2]: *** Waiting for unfinished jobs....
[build] .../filament/filament/backend/src/metal/MetalContext.mm:66:43: error: 'MTLGPUFamilyMac1' is deprecated: first deprecated in macOS 13.0 [-Werror,-Wdeprecated-declarations]
[build]         } else if ([device supportsFamily:MTLGPUFamilyMac1]) {
[build]                                           ^~~~~~~~~~~~~~~~
[build]                                           MTLGPUFamilyMac2
[build] /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/System/Library/Frameworks/Metal.framework/Headers/MTLDevice.h:210:5: note: 'MTLGPUFamilyMac1' has been explicitly marked deprecated here
[build]     MTLGPUFamilyMac1 API_DEPRECATED_WITH_REPLACEMENT("MTLGPUFamilyMac2", macos(10.15, 13.0), ios(13.0, 16.0)) = 2001,
[build]     ^
[build] 1 error generated.
[build] make[2]: ***[.../filament/filament/backend/CMakeFiles/backend.dir/src/metal/MetalContext.mm.o] Error 1
[build] .../filament/filament/backend/src/metal/MetalHandles.mm:939:64: error: 'MTLResourceUsageSample' is deprecated: first deprecated in macOS 13.0 [-Werror,-Wdeprecated-declarations]
[build]                                   usage:MTLResourceUsageRead | MTLResourceUsageSample
[build]                                                                ^~~~~~~~~~~~~~~~~~~~~~
[build]                                                                MTLResourceUsageRead
[build] /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/System/Library/Frameworks/Metal.framework/Headers/MTLCommandEncoder.h:21:2: note: 'MTLResourceUsageSample' has been explicitly marked deprecated here
[build]         MTLResourceUsageSample API_DEPRECATED_WITH_REPLACEMENT("MTLResourceUsageRead", macos(10.13, 13.0), ios(11.0, 16.0)) = 1 << 2
[build]         ^
[build] .../filament/filament/backend/src/metal/MetalHandles.mm:944:64: error: 'MTLResourceUsageSample' is deprecated: first deprecated in macOS 13.0 [-Werror,-Wdeprecated-declarations]
[build]                                   usage:MTLResourceUsageRead | MTLResourceUsageSample];
[build]                                                                ^~~~~~~~~~~~~~~~~~~~~~
[build]                                                                MTLResourceUsageRead
[build] /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/System/Library/Frameworks/Metal.framework/Headers/MTLCommandEncoder.h:21:2: note: 'MTLResourceUsageSample' has been explicitly marked deprecated here
[build]         MTLResourceUsageSample API_DEPRECATED_WITH_REPLACEMENT("MTLResourceUsageRead", macos(10.13, 13.0), ios(11.0, 16.0)) = 1 << 2
[build]         ^
[build] .../filament/filament/backend/src/metal/MetalHandles.mm:942:28: error: 'useResources:count:usage:' is deprecated: first deprecated in macOS 13.0 [-Werror,-Wdeprecated-declarations]
[build]         [renderPassEncoder useResources:textures.data()
[build]                            ^~~~~~~~~~~~
[build]                            Use useResources:count:usage:stages: instead
[build] /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/System/Library/Frameworks/Metal.framework/Headers/MTLRenderCommandEncoder.h:950:1: note: 'useResources:count:usage:' has been explicitly marked deprecated here
[build] - (void)useResources:(const id <MTLResource> __nonnull[__nonnull])resources count:(NSUInteger)count usage:(MTLResourceUsage)usage API_DEPRECATED_WITH_REPLACEMENT("Use useResources:count:usage:stages: instead", macos(10.13, 13.0), ios(11.0, 16.0));
[build] ^
[build] 3 errors generated.
[build] make[2]: *** [.../filament/filament/backend/CMakeFiles/backend.dir/src/metal/MetalHandles.mm.o] Error 1
[build] make[1]: *** [.../filament/filament/backend/CMakeFiles/backend.dir/all] Error 2
[build] make: *** [all] Error 2```

[adamwych]

If you are including Filament into an existing CMake project (through add_subdirectory), then you need to set CMAKE_OSX_DEPLOYMENT_TARGET in your project too.

Normally Filament does this in its own CMakeLists.txt, so standalone builds do work, but it does not work when adding the project through add_subdirectory - in that case for some reason CMake uses the default value.

Basically, add this ABOVE project() in your CMakeLists.txt:

if (APPLE AND NOT IOS)
    # This must be set before project() is called
    set(CMAKE_OSX_DEPLOYMENT_TARGET 10.15 CACHE STRING "")
endif()