Please replace if by if constexpr for C++ 17 and above

[SergeyKorytnik]

The following if statements should be if constexpr in C++17 and above:

draco/src/draco/attributes/geometry_attribute.h

Line 366 in b43b42c

if (std::is_integral<OutT>::value) {

draco/src/draco/attributes/geometry_attribute.h

Line 369 in b43b42c

if (!std::is_same<T, bool>::value && std::is_integral<T>::value) {

draco/src/draco/attributes/geometry_attribute.h

Line 378 in b43b42c

if (std::is_floating_point<T>::value) {

draco/src/draco/attributes/geometry_attribute.h

Line 381 in b43b42c

if (sizeof(in_value) > sizeof(double)) {

draco/src/draco/attributes/geometry_attribute.h

Line 386 in b43b42c

} else if (sizeof(in_value) > sizeof(float)) {

and not as trivial but constexpr parts from the following if statements should be extracted in separate if constexpr statements:

draco/src/draco/attributes/geometry_attribute.h

Line 407 in b43b42c

if (std::is_integral<T>::value && std::is_floating_point<OutT>::value &&

draco/src/draco/attributes/geometry_attribute.h

Line 413 in b43b42c

} else if (std::is_floating_point<T>::value &&

This way compiler warnings like

Warning	C4804	'<': unsafe use of type 'bool' in operation	

can be avoided in line

draco/src/draco/attributes/geometry_attribute.h

Line 372 in b43b42c

if (in_value < kOutMin || in_value > std::numeric_limits<OutT>::max()) {

In template bool ConvertValue(AttributeValueIndex att_id, int8_t out_num_components, OutT *out_val) const
there is a long switch that "calls"/instantiates ConvertTypedValue<bool, OutT> that in turn "calls"
ConvertComponentValue<bool, OutT> that causes the warning for ConvertComponentValue<bool, float> because language requirements.