Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail when compiling with "/fp:fast" with MSVC. #14

Open
fxb opened this issue Jul 7, 2015 · 2 comments
Open

Tests fail when compiling with "/fp:fast" with MSVC. #14

fxb opened this issue Jul 7, 2015 · 2 comments

Comments

@fxb
Copy link

fxb commented Jul 7, 2015

Checks when running "test-conversions", "test-ieee" and "test-strtod" fail, which is pretty much expected, since the fast floating-point behavior is deliberately imprecise.

See documentation here: https://msdn.microsoft.com/en-us/library/e7s85ffb.aspx

Should the library force "/fp:precise" behavior using the following pragma? Or shall it be up to the user to choose the correct floating-point behavior? In that case it would be good to add this to the documentation.

#pragma float_control(precise, on, push)
...
#pragma float_control(pop)
@fxb
Copy link
Author

fxb commented Jul 7, 2015

It seems like there are some tests in "test-strtod" that fail even with "/fp:precise". I see that some checks are already disabled for MSVC... maybe a few more need to be disabled as well. I'm using Visual Studio 2013 / 12.0.31101.00 Update 4

@floitschG
Copy link
Contributor

I currently don't have a Windows machine handy. Could you send me the tests that fail?

The tests that currently fail are errors during compile-time of the MSVC. That is, it reads some numbers the wrong way. So far there isn't any test that fails because it produces incorrect code.
thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants