New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest a rework for DictionaryData in java port. #1211

Open

XenoAmess opened this issue Oct 21, 2024 · 0 comments

XenoAmess commented Oct 21, 2024

just, don't make a 123KB class if not have to. that is not a good way.
a better practice would be:

remove the reflection in Dictionary.
rework DictionaryData to load from resources file.
move the load part from static part to method invocation part, and make a 2-step-sync to the loading part.

would be glad to impl it if you would arrange time for the code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment