Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl-c / kill does not kill maverick_api #43

Open
fnoop opened this issue Dec 19, 2018 · 4 comments
Open

ctrl-c / kill does not kill maverick_api #43

fnoop opened this issue Dec 19, 2018 · 4 comments
Assignees
Labels
bug 🐛 Something isn't working
Milestone

Comments

@fnoop
Copy link
Member

fnoop commented Dec 19, 2018

maverick_api.py does not respond to ctrl-c or external kill (SIGHUP) requests.

@SamuelDudley SamuelDudley added the bug 🐛 Something isn't working label Dec 20, 2018
@SamuelDudley SamuelDudley self-assigned this Dec 20, 2018
@fnoop
Copy link
Member Author

fnoop commented Dec 21, 2018

[dev] [mav@goodrobots ~/code/fnoop.maverick-api/maverick_api]$ ./maverick_api.py
[I 181221 22:08:50 logging:34] Loaded config options
Unable to register with master node [http://localhost:11311]: master may not be running yet. Will keep trying.
^C^C^C^C^C^C

It sometimes (often?) stops on ctrl-c after startup, but if any problem during startup it doesn't.

@SamuelDudley
Copy link
Member

There are a couple of things going on here. Firstly mavros blocks forever if it cant reach the master on the URI. This needs to be fixed with some sort of timeout.
Secondly once running we are sending the signal to an asyncio loop and such the signal names are different from a normal synchronous program. There are signal callbacks in place but they are looking for the wrong signal type.

@SamuelDudley
Copy link
Member

kill is working as expected for the program once running, still need to address the issue with rospy/mavros.

@SamuelDudley
Copy link
Member

Related #64

@SamuelDudley SamuelDudley added this to the 2.0 milestone Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants