From b1cc5135f29663b8e13ec2c4e37e02e9bd453052 Mon Sep 17 00:00:00 2001
From: Robert Goniszewski <robertgoniszewski@outlook.com>
Date: Tue, 29 Oct 2024 22:41:08 +0100
Subject: [PATCH] refactor(bulk-list): centralize bookmark management with
 dedicated store

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>
---
 src/lib/components/BulkList/BulkList.svelte   | 33 +++------
 .../BulkListItem/BulkListItem.svelte          | 10 ++-
 .../components/Pagination/Pagination.svelte   | 69 +++++++++++--------
 src/lib/stores/import-bookmarks.store.ts      | 28 ++++++++
 4 files changed, 87 insertions(+), 53 deletions(-)
 create mode 100644 src/lib/stores/import-bookmarks.store.ts

diff --git a/src/lib/components/BulkList/BulkList.svelte b/src/lib/components/BulkList/BulkList.svelte
index 0419bb7..12e36c5 100644
--- a/src/lib/components/BulkList/BulkList.svelte
+++ b/src/lib/components/BulkList/BulkList.svelte
@@ -1,40 +1,28 @@
 <script lang="ts">
-import { writable } from 'svelte/store';
+import { importBookmarkStore } from '$lib/stores/import-bookmarks.store';
+import { type Readable } from 'svelte/store';
 import BulkListItem from '../BulkListItem/BulkListItem.svelte';
 
-export let itemList = writable<BulkListItem[]>([]);
+export let itemList: Readable<BulkListItem[]>;
 export let isLoading = false;
 
-const isAnyItemSelected = writable(false);
-
-$: $isAnyItemSelected = $itemList && $itemList.some((bookmark) => bookmark.selected);
-
-const toggleItemSelection = (id: number) => {
-	$itemList = $itemList.map((item) => {
-		if (item.id === id) {
-			item.selected = !item.selected;
-		}
-		return item;
-	});
-};
 const selectAllItems = ({ target }: Event) => {
 	if (target instanceof HTMLInputElement) {
-		$itemList = $itemList.map((item) => {
-			item.selected = target.checked;
-			return item;
-		});
+		importBookmarkStore.setSelectStatusForAll(target.checked);
 	}
 };
 
 const removeSelectedItems = () => {
-	$itemList = $itemList.filter((item) => !item.selected);
+	importBookmarkStore.removeSelected();
 };
 </script>
 
 <div class="flex max-w-4xl flex-col gap-2">
 	<div class="mb-2 flex w-full items-end justify-end">
-		<button class="btn btn-primary" disabled={!$isAnyItemSelected} on:click={removeSelectedItems}
-			>DELETE</button>
+		<button
+			class="btn btn-primary"
+			disabled={!importBookmarkStore.isAnySelected}
+			on:click={removeSelectedItems}>DELETE</button>
 	</div>
 	<div class="max-h-[calc(100vh-16rem)] overflow-x-auto">
 		<table class="table table-pin-rows table-pin-cols table-xs">
@@ -62,8 +50,7 @@ const removeSelectedItems = () => {
 						category={category}
 						selected={selected}
 						isLoading={isLoading}
-						metadataFetched={!!contentHtml}
-						toggleItemSelection={toggleItemSelection} />
+						metadataFetched={!!contentHtml} />
 				{/each}
 			</tbody>
 			<!-- foot -->
diff --git a/src/lib/components/BulkListItem/BulkListItem.svelte b/src/lib/components/BulkListItem/BulkListItem.svelte
index fd3db87..8119d48 100644
--- a/src/lib/components/BulkListItem/BulkListItem.svelte
+++ b/src/lib/components/BulkListItem/BulkListItem.svelte
@@ -1,4 +1,5 @@
 <script lang="ts">
+import { importBookmarkStore } from '$lib/stores/import-bookmarks.store';
 import {
 	IconCircleDashedCheck,
 	IconExclamationCircle,
@@ -14,9 +15,12 @@ export let title: string;
 export let category: string;
 export let isLoading: boolean;
 export let metadataFetched: boolean;
-export let toggleItemSelection: (id: number) => void;
 
 let urlObj = new URL(url);
+
+const removeItem = () => {
+	importBookmarkStore.removeItem(id);
+};
 </script>
 
 <tr>
@@ -26,7 +30,7 @@ let urlObj = new URL(url);
 				type="checkbox"
 				class="checkbox"
 				bind:checked={selected}
-				on:change={() => toggleItemSelection(id)} />
+				on:change={() => importBookmarkStore.toggleSelectionForItem(id)} />
 		</label>
 	</th>
 	<td>
@@ -75,6 +79,6 @@ let urlObj = new URL(url);
 	<td><span class="link hover:link-secondary">{category}</span></td>
 	<th>
 		<button class="btn btn-ghost btn-xs text-secondary">edit</button>
-		<button class="btn btn-ghost btn-xs text-error">remove</button>
+		<button class="btn btn-ghost btn-xs text-error" on:click={removeItem}>remove</button>
 	</th>
 </tr>
diff --git a/src/lib/components/Pagination/Pagination.svelte b/src/lib/components/Pagination/Pagination.svelte
index 79ffb95..886715a 100644
--- a/src/lib/components/Pagination/Pagination.svelte
+++ b/src/lib/components/Pagination/Pagination.svelte
@@ -1,44 +1,58 @@
 <script lang="ts">
-	export let page: number = 1;
-	export let limit: number = 20;
-	export let items: number = 0;
-	export let position: 'left' | 'center' | 'right' = 'center';
+import type { Readable } from 'svelte/store';
+import { get } from 'svelte/store';
 
-	const pagesCount = Math.ceil(items / limit);
+export let page: number = 1;
+export let limit: number = 20;
+export let items: number | Readable<number> = 0;
+export let position: 'left' | 'center' | 'right' = 'center';
 
-	function handlePageChange() {
-		window.location.search = `?page=${page}&limit=${limit}`;
+let itemsCount: number;
+
+$: {
+	// NOTE: We need to subscribe to the changes so it stays reactive
+	itemsCount = typeof items === 'number' ? items : get(items);
+	if (typeof items === 'object' && 'subscribe' in items) {
+		items.subscribe((value) => {
+			itemsCount = value;
+		});
 	}
+}
+
+$: pagesCount = Math.ceil(itemsCount / limit);
+
+function handlePageChange() {
+	window.location.search = `?page=${page}&limit=${limit}`;
+}
 
-	function getMarginPosition() {
-		switch (position) {
-			case 'left':
-				return 'mr-auto';
-			case 'center':
-				return 'mx-auto';
-			case 'right':
-				return 'ml-auto';
-			default:
-				return 'mx-auto';
-		}
+function getMarginPosition() {
+	switch (position) {
+		case 'left':
+			return 'mr-auto';
+		case 'center':
+			return 'mx-auto';
+		case 'right':
+			return 'ml-auto';
+		default:
+			return 'mx-auto';
 	}
+}
 
-	const limitOptions = [10, 20, 50, 100];
+const limitOptions = [10, 20, 50, 100];
 </script>
 
-<div class={`flex gap-2 mt-8 ${getMarginPosition()}`}>
+<div class={`mt-8 flex gap-2 ${getMarginPosition()}`}>
 	<div class="tooltip" data-tip="Select page">
 		<div class="join">
 			{#if pagesCount > 0}
 				{#each Array(pagesCount) as _, i}
 					<button
 						title={`Go to page ${i + 1}`}
-						class={`join-item btn btn-md ${page === i + 1 ? 'btn-active' : ''}`}
+						class={`btn join-item btn-md ${page === i + 1 ? 'btn-active' : ''}`}
 						on:click={() => {
 							page = i + 1;
 							handlePageChange();
-						}}>{i + 1}</button
-					>
+						}}>{i + 1}</button>
 				{/each}
 			{/if}
 		</div>
@@ -47,10 +61,11 @@
 		<select
 			class="select select-bordered w-full max-w-xs"
 			on:change={(event) => {
-				limit = parseInt(event.target?.value);
-				handlePageChange();
-			}}
-		>
+				if (event.target instanceof HTMLSelectElement) {
+					limit = parseInt(event.target?.value);
+					handlePageChange();
+				}
+			}}>
 			{#each limitOptions as option}
 				<option value={option} selected={option === limit}>{option}</option>
 			{/each}
diff --git a/src/lib/stores/import-bookmarks.store.ts b/src/lib/stores/import-bookmarks.store.ts
new file mode 100644
index 0000000..bb748c1
--- /dev/null
+++ b/src/lib/stores/import-bookmarks.store.ts
@@ -0,0 +1,28 @@
+import { derived, writable } from 'svelte/store';
+
+import type { BulkListItem } from '$lib/types/common/BulkList.type';
+
+const store = writable<BulkListItem[]>([]);
+const { subscribe, set, update } = store;
+
+export const importBookmarkStore = {
+	subscribe,
+	set,
+	update,
+	addItem: (item: BulkListItem) => update((items) => [...items, item]),
+	removeItem: (itemId: number) => update((items) => items.filter((item) => item.id !== itemId)),
+	selectItem: (itemId: number) =>
+		update((items) => items.map((item) => ({ ...item, selected: item.id === itemId }))),
+	isAnySelected: derived(store, (items) => items.some((item) => item.selected)),
+	toggleSelectionForItem: (itemId: number) =>
+		update((items) =>
+			items.map((item) => ({
+				...item,
+				selected: item.id === itemId ? !item.selected : item.selected
+			}))
+		),
+	setSelectStatusForAll: (selected: boolean) =>
+		update((items) => items.map((item) => ({ ...item, selected }))),
+	removeSelected: () => update((items) => items.filter((item) => !item.selected)),
+	length: derived(store, (items) => items.length)
+};