1.52.2: tests are ignored on machines of my colleagues but on my machine I see errors from tests

[vitaly-zdanevich]

We use the same config, how is that possible?

Tried to upgrade to 1.53.3

[bombsimon]

Very hard to tell with this little information but a few things you can check:

Are you using the same OS and version?
Are you using the same version of Go?
Are you using the same tools and versions (f.ex. diff)?
Are you using any C dependencies and if so, are they installed properly and the same version?
Does the code build on both machines (does go build ./... yield any errors)?

Maybe a good idea to attach the output of running golangci-lint run -v on each computer and what does the config look like to make it easier to help.

[vitaly-zdanevich]

So now you have the same issue as your colleagues on your Gentoo machine that used to work?

golanglint-ci works ok for my colleagues on macOS and Linux - without errors from tests, on the same project.

On my machine go version go1.20.7 linux/amd64.

My output:

$ golangci-lint run -v
INFO [config_reader] Config search paths: [./ /tmp/main /tmp / /home/vitaly] 
INFO [lintersdb] Active 6 linters: [errcheck gosimple govet ineffassign staticcheck unused] 
INFO [loader] Go packages loading at mode 575 (compiled_files|exports_file|files|deps|imports|name|types_sizes) took 33.363992ms 
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 71.084µs 
INFO [linters_context/goanalysis] analyzers took 285.792982ms with top 10 stages: buildir: 168.209ms, inspect: 21.213418ms, printf: 15.815377ms, ctrlflow: 15.538308ms, fact_deprecated: 15.267005ms, SA5012: 14.27271ms, fact_purity: 12.115389ms, typedness: 11.193146ms, nilness: 11.154923ms, errcheck: 42.931µs 
INFO [runner] Issues before processing: 2, after processing: 1 
INFO [runner] Processors filtering stat (out/in): path_shortener: 1/1, sort_results: 1/1, skip_files: 2/2, autogenerated_exclude: 2/2, diff: 1/1, max_per_file_from_linter: 1/1, identifier_marker: 2/2, max_same_issues: 1/1, source_code: 1/1, uniq_by_line: 1/2, max_from_linter: 1/1, severity-rules: 1/1, fixer: 1/1, cgo: 2/2, filename_unadjuster: 2/2, path_prettifier: 2/2, nolint: 2/2, path_prefixer: 1/1, skip_dirs: 2/2, exclude: 2/2, exclude-rules: 2/2 
INFO [runner] processing took 162.397µs with stages: identifier_marker: 70.424µs, exclude-rules: 42.14µs, nolint: 17.292µs, autogenerated_exclude: 9.107µs, path_prettifier: 7.525µs, source_code: 5.501µs, skip_dirs: 3.376µs, uniq_by_line: 1.843µs, max_same_issues: 1.062µs, cgo: 841ns, path_shortener: 611ns, filename_unadjuster: 501ns, max_from_linter: 451ns, skip_files: 430ns, path_prefixer: 260ns, exclude: 211ns, severity-rules: 190ns, fixer: 180ns, max_per_file_from_linter: 180ns, diff: 171ns, sort_results: 101ns 
INFO [runner] linters took 308.715251ms with stages: goanalysis_metalinter: 308.508441ms 
main.go:6:4: Error return value is not checked (errcheck)
	fn()
	 ^
INFO File cache stats: 1 entries of total size 98B 
INFO Memory: 5 samples, avg is 115.4MB, max is 181.6MB 
INFO Execution took 344.490736ms                  
vitaly@big-black-fluid /tmp/main $ 

With your docker command:

$ docker run --rm -v $(pwd):/app -w /app golangci/golangci-lint:v1.53.3 golangci-lint run -v --no-config --disable-all --enable errcheck
level=info msg="[lintersdb] Active 1 linters: [errcheck]"
level=info msg="[loader] Go packages loading at mode 575 (compiled_files|deps|exports_file|imports|types_sizes|files|name) took 1.076763846s"
level=info msg="[runner/filename_unadjuster] Pre-built 0 adjustments in 89.889µs"
level=info msg="[linters_context/goanalysis] analyzers took 39.615µs with top 10 stages: errcheck: 39.615µs"
level=info msg="[runner] Processors filtering stat (out/in): skip_files: 1/1, skip_dirs: 1/1, cgo: 1/1, path_prettifier: 1/1, uniq_by_line: 1/1, max_same_issues: 1/1, severity-rules: 1/1, path_prefixer: 1/1, sort_results: 1/1, identifier_marker: 1/1, nolint: 1/1, filename_unadjuster: 1/1, source_code: 1/1, exclude-rules: 1/1, diff: 1/1, max_per_file_from_linter: 1/1, max_from_linter: 1/1, path_shortener: 1/1, fixer: 1/1, autogenerated_exclude: 1/1, exclude: 1/1"
level=info msg="[runner] processing took 65.583µs with stages: identifier_marker: 23.544µs, nolint: 11.752µs, exclude-rules: 8.726µs, autogenerated_exclude: 6.171µs, path_prettifier: 4.789µs, source_code: 4.138µs, skip_dirs: 2.174µs, max_same_issues: 1.022µs, uniq_by_line: 992ns, cgo: 401ns, max_from_linter: 320ns, path_shortener: 300ns, filename_unadjuster: 241ns, max_per_file_from_linter: 200ns, sort_results: 160ns, severity-rules: 150ns, exclude: 141ns, skip_files: 140ns, fixer: 121ns, diff: 51ns, path_prefixer: 50ns"
level=info msg="[runner] linters took 11.024348ms with stages: errcheck: 10.927476ms"
level=info msg="File cache stats: 1 entries of total size 98B"
main.go:6:4: Error return value is not checked (errcheck)
	fn()
	 ^
level=info msg="Memory: 12 samples, avg is 33.4MB, max is 41.9MB"
level=info msg="Execution took 1.09309338s"

Colleague macOS go version go1.20.5 darwin/arm64.

Output from my colleague for your example:

`INFO [config_reader] Config search paths: [./ /Users/tanryberdi/Desktop/self-improve/tmp/main /Users/tanryberdi/Desktop/self-improve/tmp /Users/tanryberdi/Desktop/self-improve /Users/tanryberdi/Desktop /Users/tanryberdi /Users /]
INFO [lintersdb] Active 7 linters: [errcheck gosimple govet ineffassign staticcheck typecheck unused]
INFO [loader] Go packages loading at mode 575 (name|compiled_files|exports_file|imports|types_sizes|deps|files) took 541.175875ms
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 230µs
INFO [linters_context/goanalysis] analyzers took 273.404423ms with top 10 stages: buildir: 192.313127ms, fact_deprecated: 17.398166ms, inspect: 16.289002ms, ctrlflow: 10.120916ms, printf: 9.388331ms, SA5012: 9.003628ms, fact_purity: 6.977917ms, typedness: 5.370956ms, nilness: 4.075918ms, unused: 200.917µs
INFO [runner] Issues before processing: 2, after processing: 1
INFO [runner] Processors filtering stat (out/in): filename_unadjuster: 2/2, nolint: 2/2, max_same_issues: 1/1, path_prefixer: 1/1, cgo: 2/2, skip_dirs: 2/2, exclude-rules: 2/2, max_per_file_from_linter: 1/1, path_shortener: 1/1, fixer: 1/1, path_prettifier: 2/2, exclude: 2/2, uniq_by_line: 1/2, max_from_linter: 1/1, sort_results: 1/1, skip_files: 2/2, autogenerated_exclude: 2/2, identifier_marker: 2/2, diff: 1/1, source_code: 1/1, severity-rules: 1/1
INFO [runner] processing took 231.21µs with stages: identifier_marker: 48.167µs, autogenerated_exclude: 42µs, exclude-rules: 39.126µs, nolint: 37.916µs, path_prettifier: 33.833µs, source_code: 14.5µs, skip_dirs: 7.708µs, uniq_by_line: 2.625µs, cgo: 1.751µs, max_same_issues: 1.249µs, max_from_linter: 499ns, path_shortener: 417ns, severity-rules: 334ns, fixer: 250ns, exclude: 167ns, max_per_file_from_linter: 167ns, filename_unadjuster: 167ns, skip_files: 125ns, sort_results: 84ns, diff: 83ns, path_prefixer: 42ns
INFO [runner] linters took 1.348468791s with stages: goanalysis_metalinter: 1.34813275s
main.go:6:7: Error return value is not checked (errcheck)
    fn()
      ^
INFO File cache stats: 1 entries of total size 104B
INFO Memory: 20 samples, avg is 128.2MB, max is 197.2MB
INFO Execution took 1.896399625s`

I tried your docker command in our work project - still I see error from tests, its a lot of noise :(

[bombsimon]

Oh, I think I completely misread this whole topic. 🤦 I thought this was about errors that was expected and you saw but your colleagues did not. But this is about errors in test files that you want to not see but they're still there? Sorry for the confusion.

If so, your config seems to be missing that setting. In .golangci.yml (docs):

run:
  tests: false # true by default

Or with a flag to the command line; --tests=false

› tail *.go
==> x.go <==
package x

import "errors"

func fn() error {
        return errors.New("e")
}

==> x_test.go <==
package x

import "testing"

func TestFn(t *testing.T) {
        fn()
}

› golangci-lint run --no-config --disable-all --enable errcheck
x_test.go:6:4: Error return value is not checked (errcheck)
        fn()
          ^

› golangci-lint run --no-config --disable-all --enable errcheck --tests=false

[vitaly-zdanevich]

THANKS, now no errors from tests.

But still strange - why with the same config, without run: tests: false my colleagues do not have errors about tests?

[ldez]

Ignoring tests is not a solution to your problem.
You are just hiding the problem: it's like if you have a problem with a linter and to solve the problem you just remove the linter from your configuration.

I think the problem is elsewhere and not related to golangci-lint itself as I suggested in my post.

[safisaleem]

@vitaly-zdanevich I'm going through the same issue, did you manage to find something to fix it?

[ldez]

Based on the log Active 6 linters vs Active 7 linters from this post (the difference is typecheck that I removed from the list #3929), I can say that the 2 users don't use the same version of golangci-lint.

To check the version and details:

golangci-lint version --debug

There is no reason to have a difference in test files if you are using the exact same configuration, the exact same golangci-lint version (from our binaries), the same version of Go, and the same GOOS and GOARCH.

The only things that can have an influence are:

• a build tag on a test file (but Gentoo and Ubuntu are linux based, so I don't think so)
• a wrongly compiled version of golangci-lint on Gentoo (but I don't see how to compile to have this result)
• a configuration difference (maybe you have several configuration files (in your home, in your project, etc.) [./ /tmp/main /tmp / /home/vitaly]

IMO it's a configuration issue.

I recommend creating a minimalist project based on the suggestion of this post, with only 2 files and see if the problem is still here.

Note: I don't really know Gentoo (I never tried it) but the package is really old https://packages.gentoo.org/packages/dev-go/golangci-lint, but maybe you are not using this package.