-
Notifications
You must be signed in to change notification settings - Fork 17.7k
GerritBot
GerritBot is a tool used for importing GitHub Pull Requests (PRs) into Gerrit for code review. It was created because the Go team does all its reviews in Gerrit, but we'd like to allow a more common workflow for contributing code via GitHub PRs.
- A user can upload a GitHub PR against any of our GitHub repos just as they would with any other GitHub project that accepts PRs
- The PR changes will then be imported by GerritBot and a message will be posted to the GitHub PR containing a link to the Gerrit review
- All comments are handled within Gerrit. Any comments on the GitHub PR will be ignored
- The PR author can continue to upload commits to the branch used by the PR in order to address feedback from Gerrit
- Any changes to the commit message must be done by editing the title and description of the GitHub PR, and not via Gerrit or git. (See FAQ below for details).
- Draft PRs are imported as WIP
- Once the code is ready to be merged, a maintainer will submit the change on Gerrit and GerritBot will close the issue
- Similarly, if a change is closed or abandoned on Gerrit, the corresponding PR will be closed
You need a Gmail or other Google account to register for Gerrit. This is a limitation of the infrastructure that runs our Gerrit instances and is out of our control, plus you already need a Google account to sign our CLA, a requirement for us to accept your contribution in the first place.
Replies to comments on code in Gerrit are first saved as drafts and need to be published via the “Reply” button. This is to prevent multiple emails per review “session” and is similar to the pending review workflow in GitHub. If you see a number next to the “Reply” text in the button, this means you have pending drafts to publish.
It uses the title and description of the GitHub PR to construct the commit message for the Gerrit change. You can edit this using the GitHub web interface (not Gerrit or git).
The PR description is the first text area in the "Conversation" tab of the PR. It is editable via the "..." menu. Once the PR is edited in GitHub, it can take 10 minutes or so before the Gerrit change is updated.
CL is short for "change list", which is essentially a patch proposed to be introduced into a repository. The Go project uses Gerrit to carefully review each CL. An example CL is https://go.dev/cl/508475.
Gerrit change is another term for CL.
Yes, this is highly encouraged, and a great way to familiarize yourself with Gerrit, the Go project's code review process, and the internals of the Go standard library, runtime, compiler, and so on.
You can browse the currently open CLs here and subscribe for updates to interesting CLs by clicking the star icon.
You don't need to be an expert in the code to help with initial review triage. See the section on helping to review CLs in the Gardening wiki page for more details.
You can upload as many commits as you like. GerritBot will handle squashing your commits into one change that Gerrit can handle.
This is due to an open bug with the way Gerrit handles acting as another user. Once that is fixed, the original author will also be the owner of the change.
You can toggle comments from GerritBot by using the comments slash command (e.g., /comments off).
Please file an issue and use the x/build/cmd/gerritbot: prefix in the title.
- If the feature/bug is non-trivial, please file an issue first
- The code is located at x/build/cmd/gerritbot (GitHub, Gerrit)