Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: re-enable two TLS tests with fips140tls.Required #70505

Open
cpu opened this issue Nov 21, 2024 · 1 comment
Open

crypto/tls: re-enable two TLS tests with fips140tls.Required #70505

cpu opened this issue Nov 21, 2024 · 1 comment
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@cpu
Copy link
Contributor

cpu commented Nov 21, 2024

Two small TODOs that came out of CR 629736:

  1. In handshake_server_test.go the "RSA" and "RSA with ec_point_format" subtests of TestTLSPointFormats are skipped when fips140tls.Requried() is enabled, otherwise a handshake failure error is observed. This should be debugged (I suspect I'm overlooking someting small) and the subtests re-enabled for FIPS TLS mode.

  2. The TestRenegotiationExtension test is skipped when fips140tls.Required() is enabled due to its use of RC4 ciphersuites and the RSA 1024 test certificate hiearchy. This should be possible to enable in FIPS TLS mode by replacing RC4 with an AES ciphersuite and using RSA 2048 test certs. Doing so was giving a "Server returned short message of length 7" error. This should be debugged and the test re-enabled for FIPS TLS mode.

@gabyhelp
Copy link

Related Code Changes

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@seankhliao seankhliao changed the title Re-enable two TLS tests with fips140tls.Required crypto/tls: re-enable two TLS tests with fips140tls.Required Nov 21, 2024
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 22, 2024
@dmitshur dmitshur added this to the Backlog milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants