Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/test: spurious failures due to EBADF on netbsd/arm #70492

Open
gopherbot opened this issue Nov 21, 2024 · 2 comments
Open
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Nov 21, 2024

#!watchflakes
default <- pkg ~ "golang.org/x/tools/gopls/internal/test" && `bad file descriptor` && goos == "netbsd" && goarch == "arm"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestPackageCompletion/package_completion_on_terminal_newline/default
    completion_test.go:220: completion item mismatch (-want +got):
          []string{
        - 	"package apple",
        - 	"package apple_test",
          	"package fruits",
          	"package fruits_test",
          	"package main",
          }
        
...
[Trace - 15:23:48.479 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///home/swarming/.swarming/w/ir/x/t/gopls-test-1475936701/TestPackageCompletion/package_completion_on_terminal_newline/default/work/fruits/testfile6.go","version":1,"diagnostics":[]}


[Trace - 15:23:48.486 PM] Received notification '$/progress'.
Params: {"token":"8761737497789441884","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestPackageCompletion/package_completion_on_terminal_newline/default"
--- FAIL: TestPackageCompletion/package_completion_on_terminal_newline/default (1.40s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 21, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == "TestPackageCompletion/package_completion_on_terminal_newline/default"
2024-11-20 12:37 x_tools-go1.23-netbsd-arm tools@a2874818 release-branch.go1.23@777f43ab x/tools/gopls/internal/test/integration/completion.TestPackageCompletion/package_completion_on_terminal_newline/default (log)
=== RUN   TestPackageCompletion/package_completion_on_terminal_newline/default
    completion_test.go:220: completion item mismatch (-want +got):
          []string{
        - 	"package apple",
        - 	"package apple_test",
          	"package fruits",
          	"package fruits_test",
          	"package main",
          }
        
...
[Trace - 15:23:48.479 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///home/swarming/.swarming/w/ir/x/t/gopls-test-1475936701/TestPackageCompletion/package_completion_on_terminal_newline/default/work/fruits/testfile6.go","version":1,"diagnostics":[]}


[Trace - 15:23:48.486 PM] Received notification '$/progress'.
Params: {"token":"8761737497789441884","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestPackageCompletion/package_completion_on_terminal_newline/default"
--- FAIL: TestPackageCompletion/package_completion_on_terminal_newline/default (1.40s)

watchflakes

@gopherbot
Copy link
Contributor Author

Sorry, but there were parse errors in the watch flakes script.
The script I found was:

#!watchflakes
default <- pkg ~ "golang.org/x/tools/gopls/internal/test" && `bad file descriptor` && goos == "netbsd" && goarch == "arm"

And the problems were:

script:2.18: ~ requires backquoted regexp

See https://go.dev/wiki/Watchflakes for details.

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Status: No status
Development

No branches or pull requests

1 participant