From f6d7d0eca9dce3d898067f989d04ee6f2185be12 Mon Sep 17 00:00:00 2001 From: Michael Zabka Date: Tue, 29 Dec 2020 20:38:26 +0000 Subject: [PATCH] Fix wrong condition in x11key Lookup for ASCII code * the condition was never met because rune is usually unsigned int * the logical result of checking whether unshifted key rune is ASCII is range from 0 to 0x80 --- shiny/driver/internal/x11key/x11key.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shiny/driver/internal/x11key/x11key.go b/shiny/driver/internal/x11key/x11key.go index 546d46306..9fe2cea92 100644 --- a/shiny/driver/internal/x11key/x11key.go +++ b/shiny/driver/internal/x11key/x11key.go @@ -63,7 +63,7 @@ func (t *KeysymTable) Lookup(detail uint8, state uint16) (rune, key.Code) { // The key event's code is independent of whether the shift key is down. var c key.Code - if 0 <= unshifted && unshifted < 0x80 { + if 0 >= unshifted && unshifted < 0x80 { c = asciiKeycodes[unshifted] if state&LockMask != 0 { r = unicode.ToUpper(r)