Skip to content

Commit cbc564f

Browse files
committed
tarutil: fix things for Dave
Change-Id: I2a34e3f10dad746da822ca6a368cf727e2d75844 Reviewed-on: https://go-review.googlesource.com/3700 Reviewed-by: Dave Cheney <[email protected]>
1 parent c9f3a25 commit cbc564f

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

tarutil/tarutil.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ type FileList struct {
2525
type headerContent struct {
2626
header *tar.Header
2727

28-
// For regularf files:
28+
// For regular files:
2929
size int64
3030
content io.ReaderAt
3131
}
3232

33-
// Add adds a non-regular file to the FileList.
34-
func (fl *FileList) Add(h *tar.Header) {
33+
// AddHeader adds a non-regular file to the FileList.
34+
func (fl *FileList) AddHeader(h *tar.Header) {
3535
fl.files = append(fl.files, headerContent{header: h})
3636
}
3737

@@ -44,12 +44,12 @@ func (fl *FileList) AddRegular(h *tar.Header, size int64, content io.ReaderAt) {
4444
})
4545
}
4646

47-
// OpenTarGz returns an io.Reader of a gzip-compressed tar file
47+
// TarGz returns an io.ReadCloser of a gzip-compressed tar file
4848
// containing the contents of the FileList.
4949
// All Add calls must happen before OpenTarGz is called.
5050
// Callers must call Close on the returned ReadCloser to release
5151
// resources.
52-
func (fl *FileList) OpenTarGz() io.ReadCloser {
52+
func (fl *FileList) TarGz() io.ReadCloser {
5353
pr, pw := io.Pipe()
5454
go func() {
5555
err := fl.writeTarGz(pw)

tarutil/tarutil_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@ func tarHeader(t *testing.T, fi fileInfo) *tar.Header {
4343
func TestFileList(t *testing.T) {
4444
fl := new(FileList)
4545

46-
fl.Add(tarHeader(t, fileInfo{name: "symlink-file", target: "link-target", mode: 0644 | os.ModeSymlink}))
46+
fl.AddHeader(tarHeader(t, fileInfo{name: "symlink-file", target: "link-target", mode: 0644 | os.ModeSymlink}))
4747
fl.AddRegular(tarHeader(t, fileInfo{name: "regular.txt", mode: 0644, size: 7}), 7, strings.NewReader("foo bar"))
4848

49-
tgz := fl.OpenTarGz()
49+
tgz := fl.TarGz()
5050
defer tgz.Close()
5151
zr, err := gzip.NewReader(tgz)
5252
if err != nil {

0 commit comments

Comments
 (0)