Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetID in the Claims interface ? #334

Open
Tracked by #335
zaakn opened this issue Aug 13, 2023 · 2 comments · May be fixed by #352
Open
Tracked by #335

GetID in the Claims interface ? #334

zaakn opened this issue Aug 13, 2023 · 2 comments · May be fixed by #352
Labels
next The next iteration of development, currently `v6`

Comments

@zaakn
Copy link

zaakn commented Aug 13, 2023

Is there a special consideration for the absence of the GetID() function?

https://datatracker.ietf.org/doc/html/rfc7519#section-4.1.7

jwt/claims.go

Lines 9 to 16 in 8aa5d6c

type Claims interface {
GetExpirationTime() (*NumericDate, error)
GetIssuedAt() (*NumericDate, error)
GetNotBefore() (*NumericDate, error)
GetIssuer() (string, error)
GetSubject() (string, error)
GetAudience() (ClaimStrings, error)
}

@oxisto
Copy link
Collaborator

oxisto commented Aug 14, 2023

That was probably an oversight on my part. The RegisteredClaims struct already has the appropriate field though.

Unfortunately, we cannot add anything to the interface without API breakage, meaning we need to reserve this for a potential v6.

@oxisto oxisto added the next The next iteration of development, currently `v6` label Aug 14, 2023
@oxisto oxisto mentioned this issue Aug 14, 2023
Open
10 tasks
@st3fan
Copy link

st3fan commented Oct 9, 2023

I submitted #352 earlier today.

@oxisto oxisto linked a pull request Oct 9, 2023 that will close this issue
Add ID to Claims interface #352
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next The next iteration of development, currently `v6`
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ID to Claims interface st3fan/jwt
3 participants
@st3fan @zaakn @oxisto