Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resources.ByMediaType #12874

Open
bep opened this issue Sep 23, 2024 · 0 comments
Open

Add Resources.ByMediaType #12874

bep opened this issue Sep 23, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@bep
Copy link
Member

bep commented Sep 23, 2024

Working in improving the JS build situation, I'm ending up in a situation where I get a Resources slice that contains both Javascript and CSS.

I could filter this with where, but since this will be such a common construct, I think we need to add another By* method.

We have Resources.ByType which is (a little confusingly) filtering by the media type's main type.

I suggest we add:

Resources.ByMediaType so {{ $resources.ByMediaType "text/css" }} would return what's expected.

@bep bep self-assigned this Sep 23, 2024
@bep bep removed the NeedsTriage label Sep 23, 2024
@bep bep added this to the v0.135.0 milestone Sep 23, 2024
bep added a commit to bep/hugo that referenced this issue Sep 23, 2024
bep added a commit to bep/hugo that referenced this issue Sep 23, 2024
bep added a commit to bep/hugo that referenced this issue Sep 23, 2024
bep added a commit to bep/hugo that referenced this issue Sep 24, 2024
bep added a commit to bep/hugo that referenced this issue Sep 28, 2024
@bep bep modified the milestones: v0.135.0, v0.136.0 Sep 28, 2024
bep added a commit to bep/hugo that referenced this issue Oct 12, 2024
bep added a commit to bep/hugo that referenced this issue Oct 13, 2024
bep added a commit to bep/hugo that referenced this issue Oct 13, 2024
bep added a commit to bep/hugo that referenced this issue Oct 18, 2024
bep added a commit to bep/hugo that referenced this issue Oct 19, 2024
bep added a commit to bep/hugo that referenced this issue Oct 21, 2024
bep added a commit to bep/hugo that referenced this issue Oct 22, 2024
bep added a commit to bep/hugo that referenced this issue Oct 22, 2024
bep added a commit to bep/hugo that referenced this issue Oct 22, 2024
@bep bep modified the milestones: v0.136.0, v0.137.0, v0.138.0 Oct 23, 2024
bep added a commit to bep/hugo that referenced this issue Oct 24, 2024
bep added a commit to bep/hugo that referenced this issue Oct 27, 2024
@bep bep removed this from the v0.137.0 milestone Oct 30, 2024
@bep bep added this to the v0.138.0 milestone Oct 30, 2024
bep added a commit to bep/hugo that referenced this issue Nov 6, 2024
@bep bep modified the milestones: v0.138.0, v0.139.0 Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant