fix(core): simplify admin password warning per review feedback

- Remove updateInitPasswordWithMgr wrapper function per reviewer request
- Add userID == adminUserID check before showing admin-specific warning
- Remove unit tests that depended on the removed DI pattern

Signed-off-by: thc1006 <[email protected]>

Author: thc1006

src/core/main.go

@@ -87,10 +87,7 @@ const (
 )
 
 func updateInitPassword(ctx context.Context, userID int, password string) error {
-	return updateInitPasswordWithMgr(ctx, pkguser.Mgr, userID, password)
-}
-
-func updateInitPasswordWithMgr(ctx context.Context, userMgr pkguser.Manager, userID int, password string) error {
+	userMgr := pkguser.Mgr
 	user, err := userMgr.Get(ctx, userID)
 	if err != nil {
 		return fmt.Errorf("failed to get user, userID: %d %v", userID, err)
@@ -103,7 +100,7 @@ func updateInitPasswordWithMgr(ctx context.Context, userMgr pkguser.Manager, use
 		log.Infof("User id: %d updated its encrypted password successfully.", userID)
 	} else {
 		log.Infof("User id: %d already has its encrypted password.", userID)
-		if password != "" {
+		if userID == adminUserID && password != "" {
 			log.Warningf("The admin password in configuration (HARBOR_ADMIN_PASSWORD) will not be applied " +
 				"because a password already exists in the database. To change the admin password, use the Harbor UI or API.")
 		}