gdb: The order in which Safe and OmitEmptyWhere are called causes OmitEmptyWhere to fail.

[alanhi]

Go version

go version go1.22.4 windows/amd64

GoFrame version

v2.7.2

Can this bug be reproduced with the latest release?

Option Yes

What did you do?

1. dao中增加自定义方法

func (dao tbUserDao) CtxTenant(ctx context.Context) *gdb.Model {
	return dao.DB().Model(dao.Table()).Safe().Ctx(ctx).Where("`tenant_id` = ?", "888")
}

2. 查询接口调用

record, err := dao.TbUser.CtxTenant(ctx).
	Safe(false).
	OmitEmptyWhere().
	// Safe(false).
	Where(do.TbUser{
		Name: "",
	}).
	One()

What did you see happen?

1. 调用顺序.Safe(false).OmitEmptyWhere()，sql中name条件存在

SELECT * FROM `tb_user` WHERE (`tenant_id` = '888') AND (`name`='') LIMIT 1

2. 调用顺序.OmitEmptyWhere().Safe(false)，sql中name条件不存在

SELECT * FROM `tb_user` WHERE `tenant_id` = '888' LIMIT 1

看起来是.Safe(true).Where(xxx).Safe(false).OmitEmptyWhere()这种形式会出现问题

What did you expect to see?

fix

[wln32]

初步判断原因可能是Safe机制问题

[Issues-translate-bot]

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

---

Preliminary judgment is that the cause may be a problem with the Safe mechanism.

[gqcn]

@alanhi Safe机制其实会在Model中设置标识，后续的所有链式操作都会判断是否使用浅拷贝。我理解你这里的问题是先通过链式操作修改了Model，这个时候Model已经脏了，后续再给Model设置Safe已经没有意义了。如果仍旧有问题请提交可运行的最小复现代码。

[Issues-translate-bot]

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

---

@alanhi The Safe mechanism will actually set the flag in Model, and all subsequent chain operations will determine whether to use shallow copy. I understand that your problem here is that you first modified the Model through a chain operation. At this time, the Model is already dirty, and it is meaningless to set Safe to the Model later. If you still have problems please submit a minimal working replica of the code.