add spans for tracer in onstarthook context

Author: Umang01-hash

pkg/gofr/gofr.go

@@ -12,6 +12,7 @@ import (
 	"strings"
 
 	"github.com/gorilla/mux"
+	"go.opentelemetry.io/otel"
 	"golang.org/x/sync/errgroup"
 
 	"gofr.dev/pkg/gofr/config"
@@ -21,12 +22,15 @@ import (
 	"gofr.dev/pkg/gofr/metrics"
 	"gofr.dev/pkg/gofr/migration"
 	"gofr.dev/pkg/gofr/service"
+	"gofr.dev/pkg/gofr/version"
 )
 
 const (
 	configLocation = "./configs"
 )
 
+var errStartupHookPanic = errors.New("startup hook panicked")
+
 // App is the main application in the GoFr framework.
 type App struct {
 	// Config can be used by applications to fetch custom configurations from environment or file.
@@ -50,16 +54,36 @@ type App struct {
 }
 
 func (a *App) runOnStartHooks(ctx context.Context) error {
+	// Create a span for the startup hooks execution,
+	tr := otel.GetTracerProvider().Tracer("gofr-" + version.Framework)
+
+	ctx, span := tr.Start(ctx, "startup-hooks")
+	defer span.End()
+
 	// Use the existing newContext function with noopRequest
 	gofrCtx := newContext(nil, noopRequest{}, a.container)
 
 	// Set the context for cancellation support
 	gofrCtx.Context = ctx
 
-	for _, hook := range a.onStartHooks {
-		if err := hook(gofrCtx); err != nil {
-			a.Logger().Errorf("OnStart hook failed: %v", err)
-			return err
+	for i, hook := range a.onStartHooks {
+		// Add panic recovery to prevent entire application crash
+		var hookErr error
+
+		func() {
+			defer func() {
+				if r := recover(); r != nil {
+					a.Logger().Errorf("OnStart hook %d panicked: %v", i, r)
+					hookErr = fmt.Errorf("hook %d: %w: %v", i, errStartupHookPanic, r)
+				}
+			}()
+
+			hookErr = hook(gofrCtx)
+		}()
+
+		if hookErr != nil {
+			a.Logger().Errorf("OnStart hook failed: %v", hookErr)
+			return hookErr
 		}
 
 		// Check if context was canceled

pkg/gofr/gofr_test.go

@@ -1203,4 +1203,37 @@ func TestApp_OnStart(t *testing.T) {
 
 		require.ErrorIs(t, err, errHookFailed, "Expected an error from runOnStartHooks")
 	})
+
+	// Test case 3: Verify trace context is properly set
+	t.Run("trace context", func(t *testing.T) {
+		app := New()
+
+		var traceID string
+
+		app.OnStart(func(ctx *Context) error {
+			// Verify that trace context is not empty
+			traceID = ctx.GetCorrelationID()
+			return nil
+		})
+
+		err := app.runOnStartHooks(t.Context())
+
+		require.NoError(t, err, "Expected no error from runOnStartHooks")
+		assert.NotEmpty(t, traceID, "Expected traceID to be set in OnStart hook context")
+		assert.NotEqual(t, "00000000000000000000000000000000", traceID, "Expected valid traceID, not zero value")
+	})
+
+	// Test case 4: Verify panic recovery
+	t.Run("panic recovery", func(t *testing.T) {
+		app := New()
+
+		app.OnStart(func(_ *Context) error {
+			panic("test panic")
+		})
+
+		err := app.runOnStartHooks(t.Context())
+
+		require.Error(t, err, "Expected error from panicked hook")
+		assert.Contains(t, err.Error(), "panicked", "Expected error message to mention panic")
+	})
 }