fix: max depth issues

Author: cmilesdev

README.md

@@ -11,7 +11,7 @@
     <a href="https://goreportcard.com/report/github.com/goforj/godump"><img src="https://goreportcard.com/badge/github.com/goforj/godump" alt="Go Report Card"></a>
     <a href="https://codecov.io/gh/goforj/godump" ><img src="https://codecov.io/gh/goforj/godump/graph/badge.svg?token=ULUTXL03XC"/></a>
 <!-- test-count:embed:start -->
-    <img src="https://img.shields.io/badge/tests-143-brightgreen" alt="Tests">
+    <img src="https://img.shields.io/badge/tests-156-brightgreen" alt="Tests">
 <!-- test-count:embed:end -->
     <a href="https://github.com/avelino/awesome-go?tab=readme-ov-file#parsersencodersdecoders"><img src="https://awesome.re/mentioned-badge-flat.svg" alt="Mentioned in Awesome Go"></a>
 </p>
@@ -583,9 +583,9 @@ Param n must be 0 or greater or this will be ignored, and default MaxDepth will
 v := map[string]map[string]int{"a": {"b": 1}}
 d := godump.NewDumper(godump.WithMaxDepth(1))
 d.Dump(v)
-// #map[string]int {
+// #map[string]map[string]int {
 //   a => #map[string]int {
-//     b => ... (max depth)
+//     b => 1 #int
 //   }
 // }
 ```

examples/withmaxdepth/main.go

@@ -14,9 +14,9 @@ func main() {
 	v := map[string]map[string]int{"a": {"b": 1}}
 	d := godump.NewDumper(godump.WithMaxDepth(1))
 	d.Dump(v)
-	// #map[string]int {
+	// #map[string]map[string]int {
 	//   a => #map[string]int {
-	//     b => ... (max depth)
+	//     b => 1 #int
 	//   }
 	// }
 }

godump.go

@@ -174,9 +174,9 @@ func newDumpState() *dumpState {
 //	v := map[string]map[string]int{"a": {"b": 1}}
 //	d := godump.NewDumper(godump.WithMaxDepth(1))
 //	d.Dump(v)
-//	// #map[string]int {
+//	// #map[string]map[string]int {
 //	//   a => #map[string]int {
-//	//     b => ... (max depth)
+//	//     b => 1 #int
 //	//   }
 //	// }
 func WithMaxDepth(n int) Option {
@@ -904,15 +904,22 @@ func (d *Dumper) getTypeString(t reflect.Type) string {
 }
 
 func (d *Dumper) printValue(w io.Writer, v reflect.Value, indent int, state *dumpState) {
-	if indent > d.maxDepth {
-		fmt.Fprint(w, d.colorize(colorGray, "... (max depth)"))
-		return
-	}
 	if !v.IsValid() {
 		fmt.Fprint(w, d.colorize(colorGray, "<invalid>"))
 		return
 	}
 
+	if isNil(v) {
+		typeStr := d.getTypeString(v.Type())
+		fmt.Fprintf(w, d.colorize(colorLime, typeStr)+d.colorize(colorGray, "(nil)"))
+		return
+	}
+
+	if shouldTruncateAtDepth(v, indent, d.maxDepth) {
+		fmt.Fprint(w, d.colorize(colorGray, "... (max depth)"))
+		return
+	}
+
 	if s := d.asStringer(v); s != "" {
 		fmt.Fprint(w, s)
 		return
@@ -921,18 +928,7 @@ func (d *Dumper) printValue(w io.Writer, v reflect.Value, indent int, state *dum
 	switch v.Kind() {
 	case reflect.Chan:
 		typ := d.colorizer(colorGray, d.getTypeString(v.Type()))
-
-		if v.IsNil() {
-			fmt.Fprint(w, d.colorize(colorGray, fmt.Sprintf("#%s(nil)", typ)))
-		} else {
-			fmt.Fprintf(w, "%s(%s)", d.colorize(colorGray, typ), d.colorize(colorCyan, fmt.Sprintf("%#x", v.Pointer())))
-		}
-		return
-	}
-
-	if isNil(v) {
-		typeStr := d.getTypeString(v.Type())
-		fmt.Fprintf(w, d.colorize(colorLime, typeStr)+d.colorize(colorGray, "(nil)"))
+		fmt.Fprintf(w, "%s(%s)", d.colorize(colorGray, typ), d.colorize(colorCyan, fmt.Sprintf("%#x", v.Pointer())))
 		return
 	}
 
@@ -1235,3 +1231,56 @@ func (d *Dumper) redactedValue(v reflect.Value) string {
 	typeStr := d.getTypeString(v.Type())
 	return d.colorize(colorRed, "<redacted>") + d.colorize(colorGray, " #"+typeStr)
 }
+
+func isComplexValue(v reflect.Value) bool {
+	_, ok := complexBaseKind(v)
+	return ok
+}
+
+func complexBaseKind(v reflect.Value) (reflect.Kind, bool) {
+	if !v.IsValid() {
+		return 0, false
+	}
+
+	for v.Kind() == reflect.Interface {
+		if v.IsNil() {
+			return 0, false
+		}
+		v = v.Elem()
+	}
+
+	for v.Kind() == reflect.Ptr {
+		if v.IsNil() {
+			return 0, false
+		}
+		v = v.Elem()
+	}
+
+	switch v.Kind() {
+	case reflect.Struct, reflect.Map, reflect.Slice, reflect.Array:
+		return v.Kind(), true
+	default:
+		return 0, false
+	}
+}
+
+func shouldTruncateAtDepth(v reflect.Value, indent, maxDepth int) bool {
+	if indent > maxDepth && isComplexValue(v) {
+		return true
+	}
+	if indent < maxDepth {
+		return false
+	}
+
+	kind, ok := complexBaseKind(v)
+	if !ok {
+		return false
+	}
+
+	switch kind {
+	case reflect.Map, reflect.Slice, reflect.Array:
+		return true
+	default:
+		return false
+	}
+}