Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Unclear instructions on how compiled export templates are named and should be renamed for install in templates directory #9949

Open
Fipsdot opened this issue Sep 12, 2024 · 4 comments
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation topic:buildsystem
Milestone

Comments

@Fipsdot
Copy link

Fipsdot commented Sep 12, 2024

Tested versions

Godot: 3.5.3
FreeBSD: 14.1

System information

FreeBSD 14.1, Godot 3.5.3

Issue description

I’m trying to build the export template for FreeBSD, but can’t get the files being generated. I’m using the steps documented here. However, no files called linux_x11_64_release or linux_x11_64_debug are generated. What’s the issue? Or am I misunderstanding something?

Greetings,
Fabiano

PS: Specifying module_webm_enabled=no was necessary to build without an error I will deal with in a separate thread as soon as this issue is resolved!

Steps to reproduce

git clone https://github.com/godotengine/godot.git
cd godot
git checkout 3.5.3-stable
scons platform=x11 module_webm_enabled=no
scons module_webm_enabled=no plaform=x11 tools=no target=release bits=64
scons module_webm_enabled=no plaform=x11 tools=no target=release_debug bits=64
find . -type f -name linux_x11_64_release
[nothing here]

Minimal reproduction project (MRP)

This is not project-specific

@AThousandShips
Copy link
Member

The files are under bin, what files exist there?

@AThousandShips AThousandShips changed the title Building export template for/on FreeBSD [3.x] Building export template for/on FreeBSD Sep 12, 2024
@lawnjelly lawnjelly added this to the 3.x milestone Sep 12, 2024
@akien-mga
Copy link
Member

akien-mga commented Sep 13, 2024

linux_x11_64_release is the name you should rename the generated file to.
The output of Godot's buildsystem should be something like godot.x11.opt.64.

The documentation should be edited to make this clearer, it mentions the files should be "named" but it should at least say "renamed" (but could be reworded further for clarity).

Moving to the docs repo.

@akien-mga akien-mga changed the title [3.x] Building export template for/on FreeBSD [3.x] Unclear instructions on how compiled export templates are named and should be renamed for install in templates directory Sep 13, 2024
@akien-mga akien-mga transferred this issue from godotengine/godot Sep 13, 2024
@akien-mga
Copy link
Member

Note that you don't need to do this rename at all if you just select the compiled binary as "Custom Release Template" and "Custom Debug Template" in the export preset. The rename is only if you want to install the templates where Godot expects official export templates to be installed (i.e. overriding the existing Linux/X11 ones).

@Fipsdot
Copy link
Author

Fipsdot commented Sep 13, 2024

This was the issue! Thanks for this fast clarification!

@skyace65 skyace65 added the area:contributing Issues and PRs related to the Contributing/Development section of the documentation label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation topic:buildsystem
Projects
None yet
Development

No branches or pull requests

5 participants