Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization: rbac clusterrole for crane is too open #688

Closed
fm2022aa opened this issue Feb 9, 2023 · 3 comments · Fixed by #875 · May be fixed by #732
Closed

Optimization: rbac clusterrole for crane is too open #688

fm2022aa opened this issue Feb 9, 2023 · 3 comments · Fixed by #875 · May be fixed by #732
Assignees
@lbbniu
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@fm2022aa
Copy link

fm2022aa commented Feb 9, 2023 •
edited
Loading

Describe the bug
https://github.com/gocrane/crane/blob/7b43222f8f1a73a9f32faa5ca472c632067ddbb2/deploy/craned/rbac.yaml

kind: ClusterRole
metadata:
  name: craned
rules:
  - apiGroups: [ '*' ]
    resources: [ '*' ]
    verbs: [ "*" ]

Reproduce steps
Expected behavior

Screenshots

Environment (please complete the following information):
@fm2022aa fm2022aa changed the title Optimization: rbac for crane is too open Optimization: rbac clusterrole for crane is too open Feb 9, 2023
@qmhu qmhu added enhancement New feature or request help wanted Extra attention is needed labels Feb 10, 2023
@github-actions
Copy link
Contributor

Hello @fm2022aa.
We totally like your proposal/feedback, welcome to send us a Pull Request for it.
Please send your Pull Request to main branch, fill the Pull Request Template here, provide changelog/documentation/test cases if needed and make sure CI passed, we will review it soon.
We appreciate your effort in advance and looking forward to your contribution!

你好 @fm2022aa，我们完全同意你的提议/反馈。
欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。
请将 Pull Request 发到 main 分支，务必填写 Pull Request 内的预设模板，提供改动所需相应的 changelog、测试用例、文档等，并确保 CI 通过。
我们会尽快进行 Review，提前感谢和期待您的贡献。

@qmhu
Copy link
Member

qmhu commented Feb 10, 2023 •
edited
Loading

Agreed, would you like to enhance it?

@lbbniu
Copy link
Member

lbbniu commented Feb 13, 2023

assign me?

@lbbniu lbbniu mentioned this issue Apr 23, 2023
Open
@Cloudzp Cloudzp mentioned this issue Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbbniu lbbniu

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

optimize craned rbac config Cloudzp/crane
[WIP]perf: optimize craned rbac config lbbniu/crane
3 participants
@lbbniu @qmhu @fm2022aa