Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid populating dep table in TD3 when non-incremental #1566

Open
sim642 opened this issue Sep 6, 2024 · 0 comments
Open

Avoid populating dep table in TD3 when non-incremental #1566

sim642 opened this issue Sep 6, 2024 · 0 comments
Labels
bug good first issue performance Analysis time, memory usage

Comments

@sim642
Copy link
Member

sim642 commented Sep 6, 2024

It looks like TD3 populates the dep table along with infl. If I recall correctly, dep is just used for some incremental things, so it's useless during non-incremental runs and can grow quite large.
If this is the case, then we should probably avoid populating it unnecessarily.
@sim642 sim642 added bug performance Analysis time, memory usage labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue performance Analysis time, memory usage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sim642