fix(compiler): prevent same-name stages in pipeline configs (#1360)

* fix(compiler): prevent same-name stages in pipeline configs

* lintfix

Author: ecrupper

compiler/native/validate.go

@@ -166,10 +166,17 @@ func validatePipelineStages(s pipeline.StageSlice) error {
 	reportMap := make(map[string]string)
 	reportCount := 0
 
-	nameMap := make(map[string]bool)
+	stageNameMap := make(map[string]bool)
+	stepNameMap := make(map[string]bool)
 
 	for _, stage := range s {
-		err := validatePipelineContainers(stage.Steps, &reportCount, reportMap, nameMap, stage.Name)
+		if _, ok := stageNameMap[stage.Name]; ok {
+			return fmt.Errorf("stage `%s` is already defined", stage.Name)
+		}
+
+		stageNameMap[stage.Name] = true
+
+		err := validatePipelineContainers(stage.Steps, &reportCount, reportMap, stepNameMap, stage.Name)
 		if err != nil {
 			return err
 		}

compiler/native/validate_test.go

@@ -256,6 +256,51 @@ func TestNative_Validate_Stages(t *testing.T) {
 	}
 }
 
+func TestNative_Validate_StagesSameName(t *testing.T) {
+	// setup types
+	strFoo := "foo"
+	strBar := "bar"
+
+	p := &pipeline.Build{
+		Version: "v1",
+		Stages: pipeline.StageSlice{
+			&pipeline.Stage{
+				Name: strFoo,
+				Steps: pipeline.ContainerSlice{
+					&pipeline.Container{
+						Commands: raw.StringSlice{"echo hello"},
+						Image:    "alpine",
+						Name:     strFoo,
+						Pull:     "always",
+					},
+				},
+			},
+			&pipeline.Stage{
+				Name: strFoo,
+				Steps: pipeline.ContainerSlice{
+					&pipeline.Container{
+						Commands: raw.StringSlice{"echo hello"},
+						Image:    "alpine",
+						Name:     strBar,
+						Pull:     "always",
+					},
+				},
+			},
+		},
+	}
+
+	// run test
+	compiler, err := FromCLICommand(context.Background(), testCommand(t, "http://foo.example.com"))
+	if err != nil {
+		t.Errorf("Unable to create new compiler: %v", err)
+	}
+
+	err = compiler.ValidatePipeline(p)
+	if err == nil {
+		t.Errorf("Validate should have returned err")
+	}
+}
+
 func TestNative_Validate_Stages_NoName(t *testing.T) {
 	// setup types
 	str := "foo"

router/middleware/tracing_test.go

@@ -67,6 +67,7 @@ func TestMiddleware_TracingInstrumentation(t *testing.T) {
 				if !reflect.DeepEqual(got, trace.SpanContext{}) {
 					return errors.New("span context is not empty")
 				}
+
 				return nil
 			},
 		},
@@ -82,6 +83,7 @@ func TestMiddleware_TracingInstrumentation(t *testing.T) {
 				if reflect.DeepEqual(got, trace.SpanContext{}) {
 					return errors.New("span context is empty")
 				}
+
 				return nil
 			},
 		},