add a server-side function to support sasl binding step by step #430
Conversation
| // ServerBindStep sends the SASLBindRequest and return the result code, servercred and errors. | ||
| // If the result code is not SUCCESS(0x00) or IN_PROGRESS(0x0e), it's also considered as an error. | ||
| func (l *Conn) ServerBindStep(clientCred []byte, dn string, methodName string, controls []Control) (resultCode uint16, serverCred []byte, err error) { | ||
| packet := ber.Encode(ber.ClassUniversal, ber.TypeConstructed, ber.TagSequence, nil, "LDAP Request") |
There was a problem hiding this comment.
Most of this (until line 770) is a duplication of what doRequest does. The function signature also mismatches from the style how other functions like SimpleBind are structure. They take in a struct (which also satisfies the request interface). Additionally, there are simple wrappers for those functions like conn.Bind for simple use.
In my opinion we should stick to one style here and not mix them up. Could you please adapt your two functions please?
| // TODO: add global constants. As this package used `uint16` to represent the result code nearly everywhere, | ||
| // these constants were | ||
| const LDAPResultCodeSuccess = 0 | ||
| const LDAPResultCodeSASLBindInProgress = 0x0e |
There was a problem hiding this comment.
Both values are already defined in error.go, thought they're of type int unfortunately. I think it can stay like this and we take care of this later on 😄
| @@ -733,3 +733,115 @@ RESP: | |||
|
|
|||
| return nil, GetLDAPError(packet) | |||
| } | |||
|
|
|||
| // ServerBindStep sends the SASLBindRequest and return the result code, servercred and errors. | |||
There was a problem hiding this comment.
Can you please add a short example on how to use this function to our tests? Thank you!
Signed-off-by: Yang Keao <[email protected]>
YangKeao
force-pushed
the
bind-step-by-step
branch
from
a1003a3 to
369a3ba
Compare
close #429
Provide a function
ServerBindStepto send sasl bind request step by step. It returns the result code, server cred and the errors. Now it only includes the server-side.I have tested it in my situation, and it works pretty fine (but unfortunately I cannot show related codes now). If examples / tests are needed, I could add another commit to this PR several weeks later 🍻 .
Also, thanks for authors/reviewers of this repo. It's awesome 👍 .