Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move RepoTransfer from models to models/repo sub package #32506

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Move RepoTransfer from models to models/repo sub package #32506

wants to merge 8 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 14, 2024 •
edited
Loading

RepoTransfer now is at models, but if we want to move it into repo model, it will depend on Team. So this PR also makes repo model depend on org model to make it possible.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 14, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 14, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Nov 14, 2024
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 14, 2024
@wxiaoguang
Copy link
Contributor

Why? What's the benefit?

@lunny
Copy link
Member Author

lunny commented Nov 14, 2024

Why? What's the benefit?

I updated the description to explain the reason.

@wxiaoguang
Copy link
Contributor

Why not totally decouple the repo & org models? Just use them from service packages?

@lunny
Copy link
Member Author

lunny commented Nov 16, 2024 •
edited
Loading

Why not totally decouple the repo & org models? Just use them from service packages?

RepoTransfer now is at models, but if we want to move it into repo model, it will depend on Team, this is another reason why we need this change.
And we cannot move RepoTransfer to service layer.
Included moving RepoTransfer to models/repo sub package.

@lunny lunny changed the title Make repo model depends on org model but not opposite Move RepoTransfer from models to models/repo sub package Nov 17, 2024
@lunny lunny mentioned this pull request Nov 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lunny @wxiaoguang @GiteaBot