-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: phase 1 changes: add comments feat to unchanged lines in the pullrequest #32471
Open
rajesh-jonnalagadda
wants to merge
14
commits into
go-gitea:main
Choose a base branch
from
rajesh-jonnalagadda:feat-32257-add-comments-unchanged-lines-and-show
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: phase 1 changes: add comments feat to unchanged lines in the pullrequest #32471
rajesh-jonnalagadda
wants to merge
14
commits into
go-gitea:main
from
rajesh-jonnalagadda:feat-32257-add-comments-unchanged-lines-and-show
+284
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Nov 11, 2024
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Nov 11, 2024
github-actions
bot
added
modifies/go
Pull requests that update Go code
modifies/templates
This PR modifies the template files
labels
Nov 11, 2024
rajesh-jonnalagadda
force-pushed
the
feat-32257-add-comments-unchanged-lines-and-show
branch
2 times, most recently
from
November 11, 2024 02:46
e59800b
to
ed80303
Compare
rajesh-jonnalagadda
force-pushed
the
feat-32257-add-comments-unchanged-lines-and-show
branch
from
November 11, 2024 03:34
ed80303
to
abd1d2f
Compare
rajesh-jonnalagadda
force-pushed
the
feat-32257-add-comments-unchanged-lines-and-show
branch
from
November 11, 2024 17:27
8c34f45
to
7c39ad2
Compare
rajesh-jonnalagadda
force-pushed
the
feat-32257-add-comments-unchanged-lines-and-show
branch
from
November 11, 2024 17:50
3fbf96f
to
ccd797a
Compare
@lunny Can you please review |
@lunny Could you please review my changes? If the PR isn't relevant, feel free to close it. |
I will review it in the following week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🙋 Bounty claim
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
modifies/go
Pull requests that update Go code
modifies/templates
This PR modifies the template files
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #32257
demo video: phase 1
https://www.loom.com/share/36284c2b94d7478eb9cc5fd3104d8511