Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expansions to the pull review API #32898

Open
5 tasks
GamerGirlandCo opened this issue Dec 18, 2024 · 0 comments
Open
5 tasks

expansions to the pull review API #32898

GamerGirlandCo opened this issue Dec 18, 2024 · 0 comments
Labels
topic/api Concerns mainly the API type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@GamerGirlandCo
Copy link

GamerGirlandCo commented Dec 18, 2024

Feature Description

As of now you can create and delete reviews, but you can't update them (or comments within them) via the API. While you can respond to review comments via the web interface, the API doesn't provide that functionality.

I'd like to see:

  • a PATCH endpoint for reviews
  • a PATCH endpoint for a specific review comment
  • a DELETE endpoint for a specific review comment
  • POST endpoints to mark a file as "viewed" or "unviewed"
  • a GET endpoint to fetch a pull review comment's children apparently there's no concept of parent or child comments
  • a POST endpoint to reply to a pull review comment (see above remark)
  • a POST endpoint to add a new comment to a review

I'd be happy to open a few pull requests to get these implemented :)

Screenshots

No response

@GamerGirlandCo GamerGirlandCo added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Dec 18, 2024
@kemzeb kemzeb added the topic/api Concerns mainly the API label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/api Concerns mainly the API type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

2 participants