Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: passkey login not working anymore #32623

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: passkey login not working anymore #32623

wants to merge 2 commits into from
+3 −0

Conversation

hiifong
Copy link
Contributor

@hiifong hiifong commented Nov 23, 2024 •
edited
Loading

Quick fix #32595，set the default value of BackupEligible to true，maybe we should store CredentialFlags in the database, ref: https://www.w3.org/TR/webauthn-3/#credential-record

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 23, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2024
@hiifong hiifong changed the title Fix #32595 Fix: passkey login not working anymore Nov 23, 2024
@hiifong hiifong marked this pull request as draft November 23, 2024 15:18
@github-actions github-actions bot added modifies/go Pull requests that update Go code and removed modifies/dependencies labels Nov 23, 2024
@hiifong hiifong marked this pull request as ready for review November 23, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passkey login not working anymore
2 participants
@hiifong @GiteaBot