Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking Star/Unstar, Watch/Unwatch buttons on star list or watch list page result in inconsistent result. #32561

Closed
lunny opened this issue Nov 19, 2024 · 1 comment · Fixed by #32570
Closed

Clicking Star/Unstar, Watch/Unwatch buttons on star list or watch list page result in inconsistent result. #32561

lunny opened this issue Nov 19, 2024 · 1 comment · Fixed by #32570
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@lunny
Copy link
Member

lunny commented Nov 19, 2024 •
edited
Loading

Description

On watch list page, click watch/unwatch button, the button's state will be changed but the list will not be reloaded. So the number of watching is not equal to the total of watch users on this page. The same as star list page.

Regression from #29001

Gitea Version

1.22
@lunny lunny added type/bug topic/ui Change the appearance of the Gitea UI labels Nov 19, 2024
@lunny lunny changed the title Click Star/Unstar, Watch/Unwatch buttons on star list or watch list page result in inconsistent result. Clicking Star/Unstar, Watch/Unwatch buttons on star list or watch list page result in inconsistent result. Nov 19, 2024
@yardenshoham yardenshoham mentioned this issue Nov 19, 2024
Merged
@yardenshoham
Copy link
Member

#32570

@lunny lunny closed this as completed in f2a9951 Nov 22, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 20, 2025
richmahn pushed a commit to unfoldingWord/dcs that referenced this issue Mar 2, 2025
@yardenshoham @wxiaoguang
@silverwind @richmahn
Update the list of watchers and stargazers when clicking watch/unwatc…
870c81f 
…h or star/unstar (#32570)

We make sure the user cards are updated

- Fixes go-gitea/gitea#32561

I also removed `ctx.Data["PageIsWatchers"] = true` and
`ctx.Data["PageIsStargazers"] = true` as they are not used anywhere.

# Before

![before](https://github.com/user-attachments/assets/e3bc3235-35eb-4eda-862d-bdf2510282ea)

# After

![after](https://github.com/user-attachments/assets/bc0488a5-8399-4cf6-95c9-17328a9702eb)

---------

Signed-off-by: Yarden Shoham <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
Co-authored-by: silverwind <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
2 participants
@lunny @yardenshoham