Remove unnecessary code (#32560)

lunny · web-flow · commit 0d5abd9b3e04 · 2024-11-19T16:21:13.000Z
PushMirrors only be used in the repository setting page. So it should
not be loaded on every repository page.
diff --git a/services/context/repo.go b/services/context/repo.go
@@ -393,14 +393,7 @@ func repoAssignment(ctx *Context, repo *repo_model.Repository) {
 		}
 	}
 
-	pushMirrors, _, err := repo_model.GetPushMirrorsByRepoID(ctx, repo.ID, db.ListOptions{})
-	if err != nil {
-		ctx.ServerError("GetPushMirrorsByRepoID", err)
-		return
-	}
-
 	ctx.Repo.Repository = repo
-	ctx.Data["PushMirrors"] = pushMirrors
 	ctx.Data["RepoName"] = ctx.Repo.Repository.Name
 	ctx.Data["IsEmptyRepo"] = ctx.Repo.Repository.IsEmpty
 

Original file line number	Diff line number	Diff line change
`@@ -393,14 +393,7 @@ func repoAssignment(ctx Context, repo repo_model.Repository) {`
`393`	`393`	`}`
`394`	`394`	`}`
`395`	`395`
`396`		`- pushMirrors, _, err := repo_model.GetPushMirrorsByRepoID(ctx, repo.ID, db.ListOptions{})`
`397`		`- if err != nil {`
`398`		`- ctx.ServerError("GetPushMirrorsByRepoID", err)`
`399`		`- return`
`400`		`- }`
`401`		`-`
`402`	`396`	`ctx.Repo.Repository = repo`
`403`		`- ctx.Data["PushMirrors"] = pushMirrors`
`404`	`397`	`ctx.Data["RepoName"] = ctx.Repo.Repository.Name`
`405`	`398`	`ctx.Data["IsEmptyRepo"] = ctx.Repo.Repository.IsEmpty`
`406`	`399`