Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate "pub" to use new Resolvers and generated types #90

Closed
cjslep opened this issue Jan 26, 2019 · 8 comments
Closed

Migrate "pub" to use new Resolvers and generated types #90

cjslep opened this issue Jan 26, 2019 · 8 comments
Assignees
@cjslep
Labels
feature request New request for novel functionality
Milestone
1.0.0

Comments

@cjslep
Copy link
Member

cjslep commented Jan 26, 2019

No description provided.

@cjslep cjslep added the feature request New request for novel functionality label Jan 26, 2019
@cjslep cjslep added this to the 1.0.0 milestone Jan 26, 2019
@cjslep cjslep mentioned this issue Jan 26, 2019
Closed
@cjslep cjslep self-assigned this Feb 9, 2019
@cjslep
Copy link
Member Author

cjslep commented Feb 11, 2019

This has begun the core of the migration for the pub part:
16af404
Since pub/old is now broken, it is safe to delete the old vocabulary.

@cjslep
Copy link
Member Author

cjslep commented Feb 12, 2019

Ongoing
c194883

@cjslep
Copy link
Member Author

cjslep commented Feb 13, 2019

1b7cec2

@cjslep
Copy link
Member Author

cjslep commented Feb 13, 2019

Still not done yet
0f7dce6

@cjslep
Copy link
Member Author

cjslep commented Feb 14, 2019

Core of pub has been ported.
d3b0afe

Still have:

  • Tests
  • Handlers

@cjslep
Copy link
Member Author

cjslep commented Feb 14, 2019

Handler has been ported:
8efdb62

All that is left is unit tests.

Note that the old pub code has been deleted.

@cjslep
Copy link
Member Author

cjslep commented Feb 15, 2019

Tons of updates...
bd8220a
cc83b75
6ead50c
7beac61
b625914
2099e89
c4a7b05
1227ec9
2d8651d

I'm going to finish one last TODO that is lingering in Pub, file an issue for another lingering TODO which won't be addressed in v1.0.0, and file an issue for testing the new pub package.

Then I'll close this issue.

@cjslep
Copy link
Member Author

cjslep commented Feb 15, 2019

Filed #104 and #105.

Did:
272d723
412c673
8a333d6
4b87e63
3180eaf
674fa02
dc16296

Closing this issue since pub is now ported over.

@cjslep cjslep closed this as completed Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjslep cjslep

Labels
feature request New request for novel functionality
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@cjslep