Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs don't specify package name for some types #138

Open
Sigafoos opened this issue Jul 11, 2020 · 1 comment
Open

Docs don't specify package name for some types #138

Sigafoos opened this issue Jul 11, 2020 · 1 comment
Assignees

Comments

@Sigafoos
Copy link
Contributor

Please Describe The Problematic Behavior
Copying the stubbed out code from the documentation (which is very helpful, by the way!) produces errors like these:

activitypub/activitypub.go:74:94: undefined: Activity
activitypub/activitypub.go:92:72: undefined: FederatingWrappedCallbacks
activitypub/activitypub.go:98:68: undefined: Activity
activitypub/activitypub.go:116:94: undefined: Activity

Please Describe The Expected Behavior
The examples should be like this

func (*myService) PostInboxRequestBodyHook(c context.Context,
	r *http.Request,
	activity pub.Activity) (context.Context, error) {
	// TODO
	return nil, nil
}

Note pub.Activity instead of Activity

@cjslep
Copy link
Member

cjslep commented Jul 15, 2020

Thanks! Also, it's OK to file the website issues here. But the site's repository is also available (and monitored) at: https://github.com/go-fed/site

@cjslep cjslep self-assigned this Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants