-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signing on Windows: "Windows protected your PC" #95
Comments
No idea why this happens...? Will need to investigate. |
I was not sure whether we have Windows signing at the moment of filing.
If we do sign and this happens, perhaps adjusting Windows settings could address that? Maybe there is a similar trust level hierarchy "app store approved" / "signed" / "unsigned" on Windows, I’m going to have that investigated…
… On 31 Jul 2020, at 9:47 AM, Ronald Tse ***@***.***> wrote:
No idea why this happens...? Will need to investigate.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
(although “Unknown published” must mean something is not right with signing)
… On 31 Jul 2020, at 9:47 AM, Ronald Tse ***@***.***> wrote:
No idea why this happens...? Will need to investigate.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Yes we have Windows signing; previously the signing worked -- no warning was displayed on my Windows machine on launch of the application. The Windows code signing certificate is from DigiCert. |
@ronaldtse it appears that this warning is displayed only when you open the app for the first time. (Presumably, for each new version too.) I still think it has something to do with signing |
It was confirmed with latest v1.6.17 |
We're apparently missing Windows signing in this repo. |
The issue is still present in the latest version Glossarist 1.6.38. |
Windows signing in this repo is enabled, and you can see in the build logs. It seems to succeed. https://github.com/glossarist/glossarist-desktop/runs/1135873363?check_suite_focus=true
Perhaps if someone can show the signature details using SignTool.exe? |
@batyr-tar will take a look at it |
So far I think these are two somewhat separate issues:
|
Once proper signature is confirmed, I think we can consider this screen “unfixable” until Microsoft’s reputation black box starts favoring us. |
Thanks @batyr-tar |
Same error on another Windows machine:
|
This may be related... https://docs.microsoft.com/en-us/security/trusted-root/2020/july2020
Apparently it is supposed to be around? Woot? |
Ah, someone else has run into this issue: storj-archived/storjshare-gui#36 (comment) |
yes, saw that issue too
the certificate is supposed to be trusted since July so it's unclear why it's an error
note that those guys don't get verification error from signtool but we do!
… On 21 Sep 2020, at 9:56 AM, Ronald Tse ***@***.***> wrote:
Ah, someone else has run into this issue: storj-archived/storjshare-gui#36 (comment)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
The text was updated successfully, but these errors were encountered: