-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parent concepts (domains) flicker in concept list #138
Comments
This does not affect Geolexica glossary yet. Specifying domain as “parent relationship” is the proper way of specifying a domain. However, Geolexica glossary was not yet migrated to the normalized way of specifying domains, and domains are still naively specified as part of designation expression. (This is bad because if, e.g., a domain changes then all concepts in that domain must be updated.) The flickering concerns the new way of specifying concept domains by linking them as “parents” to given concept. Concept(s) linked as parents to any given concept are shown as domains next to its representing designation. When concepts are shown in a list, those parent concepts in angular brackets flicker. |
If you need help finding relevant logic in the code, feel free to ask. |
What is git repository url for domain which has parent concept? I cannot create "parents" of concept |
@strogonoff is my understanding wrong? Could you help me please... |
Parent concept labels are lazily loaded from concept refs, they are fetched on every event and while they are fetched they are shown as IDs, which causes them to flicker on various user interactions, including selecting another concept in list.
This could probably be addressed with memoizing on some level. (However, it’s important to avoid a situation where stale parent concept label is shown)
The text was updated successfully, but these errors were encountered: